Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1065833002: Revert of Fix scoped_ptr free to use delete [] instead of delete. (Closed)

Created:
5 years, 8 months ago by kcarattini
Modified:
5 years, 8 months ago
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix scoped_ptr free to use delete [] instead of delete. (patchset #1 id:1 of https://codereview.chromium.org/1055433003/) Reason for revert: It looks like this broke the following test on XP Tests (1): sbox_unittests WinUtils.SameObject Example output: WinUtils.SameObject (run #1): [ RUN ] WinUtils.SameObject c:\b\build\slave\win_builder\build\src\sandbox\win\src\win_utils_unittest.cc(78): error: Value of: SameObject(file.Get(), file_name_nt1.c_str()) Actual: false Expected: true c:\b\build\slave\win_builder\build\src\sandbox\win\src\win_utils_unittest.cc(79): error: Value of: SameObject(file.Get(), file_name_nt2.c_str()) Actual: false Expected: true [ FAILED ] WinUtils.SameObject (16 ms) Original issue's description: > Fix scoped_ptr free to use delete [] instead of delete. > > BUG=101717 > > Committed: https://crrev.com/7804b679be3af7e24578394af0a85ba1249344a9 > Cr-Commit-Position: refs/heads/master@{#324013} TBR=cpu@chromium.org,wfh@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=101717 Committed: https://crrev.com/2a02e87219ffae9473c3bb2fcdc5c31adc1dfc43 Cr-Commit-Position: refs/heads/master@{#324016}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M sandbox/win/src/win_utils.cc View 1 chunk +12 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kcarattini
Created Revert of Fix scoped_ptr free to use delete [] instead of delete.
5 years, 8 months ago (2015-04-07 06:59:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1065833002/1
5 years, 8 months ago (2015-04-07 06:59:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 07:00:27 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 07:01:19 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a02e87219ffae9473c3bb2fcdc5c31adc1dfc43
Cr-Commit-Position: refs/heads/master@{#324016}

Powered by Google App Engine
This is Rietveld 408576698