Fix scoped_ptr free to use delete [] instead of delete.

Fix scoped_ptr free to use delete [] instead of delete.

BUG=101717
Committed: https://crrev.com/7804b679be3af7e24578394af0a85ba1249344a9
Cr-Commit-Position: refs/heads/master@{#324013}

[Will Harris, 2015-04-01 21:25:00]

wfh@chromium.org changed reviewers:
+ cpu@chromium.org

[Will Harris, 2015-04-01 21:25:00]

PTAL. old bug :)

[Will Harris, 2015-04-03 02:50:35]

On 2015/04/01 21:25:00, Will Harris wrote:
> PTAL. old bug :)

ping cpu@

[cpu_(ooo_6.6-7.5), 2015-04-07 01:45:54]

lgtm

[Will Harris, 2015-04-07 02:34:17]

The CQ bit was checked by wfh@chromium.org

[commit-bot: I haz the power, 2015-04-07 02:34:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1055433003/1

[commit-bot: I haz the power, 2015-04-07 04:05:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-04-07 04:06:21]

Patchset 1 (id:??) landed as
https://crrev.com/7804b679be3af7e24578394af0a85ba1249344a9
Cr-Commit-Position: refs/heads/master@{#324013}

[kcarattini, 2015-04-07 06:59:32]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1065833002/ by kcarattini@chromium.org.

The reason for reverting is: It looks like this broke the following test on XP
Tests (1):
sbox_unittests WinUtils.SameObject 

Example output:
WinUtils.SameObject (run #1):
[ RUN      ] WinUtils.SameObject
c:\b\build\slave\win_builder\build\src\sandbox\win\src\win_utils_unittest.cc(78):
error: Value of: SameObject(file.Get(), file_name_nt1.c_str())
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\sandbox\win\src\win_utils_unittest.cc(79):
error: Value of: SameObject(file.Get(), file_name_nt2.c_str())
  Actual: false
Expected: true
[  FAILED  ] WinUtils.SameObject (16 ms).

[kcarattini, 2015-04-07 07:04:40]

On 2015/04/07 06:59:32, kcarattini wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1065833002/ by mailto:kcarattini@chromium.org.
> 
> The reason for reverting is: It looks like this broke the following test on XP
> Tests (1):
> sbox_unittests WinUtils.SameObject 
> 
> Example output:
> WinUtils.SameObject (run #1):
> [ RUN      ] WinUtils.SameObject
>
c:\b\build\slave\win_builder\build\src\sandbox\win\src\win_utils_unittest.cc(78):
> error: Value of: SameObject(file.Get(), file_name_nt1.c_str())
>   Actual: false
> Expected: true
>
c:\b\build\slave\win_builder\build\src\sandbox\win\src\win_utils_unittest.cc(79):
> error: Value of: SameObject(file.Get(), file_name_nt2.c_str())
>   Actual: false
> Expected: true
> [  FAILED  ] WinUtils.SameObject (16 ms).

Example failure build:
https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/build...

[Will Harris, 2015-04-08 00:09:55]

On 2015/04/07 07:04:40, kcarattini wrote:
> On 2015/04/07 06:59:32, kcarattini wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/1065833002/ by
mailto:kcarattini@chromium.org.
> > 
> > The reason for reverting is: It looks like this broke the following test on
XP
> > Tests (1):
> > sbox_unittests WinUtils.SameObject 
> > 
> > Example output:
> > WinUtils.SameObject (run #1):
> > [ RUN      ] WinUtils.SameObject
> >
>
c:\b\build\slave\win_builder\build\src\sandbox\win\src\win_utils_unittest.cc(78):
> > error: Value of: SameObject(file.Get(), file_name_nt1.c_str())
> >   Actual: false
> > Expected: true
> >
>
c:\b\build\slave\win_builder\build\src\sandbox\win\src\win_utils_unittest.cc(79):
> > error: Value of: SameObject(file.Get(), file_name_nt2.c_str())
> >   Actual: false
> > Expected: true
> > [  FAILED  ] WinUtils.SameObject (16 ms).
> 
> Example failure build:
>
https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/build...

It seems on Windows XP NtQueryObject returns STATUS_INFO_LENGTH_MISMATCH but
does not return the required size, contrary to MSDN docs.  This is probably why
the original code started by having an initial_buffer on the stack.  Oh, Windows
XP, can I count the number of ways I hate thee?