Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 1065463002: cc: Remove GLC macro (Closed)

Created:
5 years, 8 months ago by enne (OOO)
Modified:
5 years, 8 months ago
Reviewers:
danakj
CC:
cc-bugs_chromium.org, chromium-reviews, dshwang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove GLC macro This macro is no longer needed, as the command buffer can do the same thing with GL_CLIENT_FAIL_GL_ERRORS in gles2_implementation.h. Committed: https://crrev.com/a14e0747acab11a2bc33525ccb1cd92b79bf92b9 Cr-Commit-Position: refs/heads/master@{#323863}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -454 lines) Patch
M cc/output/dynamic_geometry_binding.cc View 3 chunks +13 lines, -14 lines 0 comments Download
M cc/output/geometry_binding.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/geometry_binding.cc View 3 chunks +11 lines, -18 lines 0 comments Download
M cc/output/gl_renderer.h View 2 chunks +0 lines, -17 lines 0 comments Download
M cc/output/gl_renderer.cc View 60 chunks +203 lines, -310 lines 0 comments Download
M cc/output/shader.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/output/static_geometry_binding.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M cc/resources/resource_provider.cc View 16 chunks +46 lines, -71 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 3 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
enne (OOO)
5 years, 8 months ago (2015-04-04 00:06:43 UTC) #2
danakj
LGTM
5 years, 8 months ago (2015-04-04 00:10:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1065463002/1
5 years, 8 months ago (2015-04-04 00:10:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-04 01:05:28 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-04 01:06:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a14e0747acab11a2bc33525ccb1cd92b79bf92b9
Cr-Commit-Position: refs/heads/master@{#323863}

Powered by Google App Engine
This is Rietveld 408576698