Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1064133003: ui: Use a PaintRecorder to access the Canvas for painting. (Closed)

Created:
5 years, 8 months ago by danakj
Modified:
5 years, 8 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tdanderson+views_chromium.org, msw+watch_chromium.org, sadrul, tfarina, kalyank, alicet1, enne (OOO), piman, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: Use a PaintRecorder to access the Canvas for painting. Don't use the canvas() from the PaintContext so that we can have the PaintContext be backed by a DisplayItemList instead in the future. Access to the Canvas should be done through a PaintRecorder. R=sadrul BUG=466426 Committed: https://crrev.com/533d7341af315b7c25bf0269314c8c2e50aa5ca5 Cr-Commit-Position: refs/heads/master@{#324137}

Patch Set 1 #

Total comments: 2

Patch Set 2 : ui-recorder: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -66 lines) Patch
M ui/aura/bench/bench_main.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/aura/test/test_window_delegate.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 2 chunks +0 lines, -42 lines 0 comments Download
M ui/aura_extra/aura_extra.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura_extra/image_window_delegate.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M ui/snapshot/snapshot_aura_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/views/bubble/tray_bubble_view.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/views/view.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/wm/core/image_grid.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
danakj
5 years, 8 months ago (2015-04-07 20:25:37 UTC) #1
sadrul
lgtm https://codereview.chromium.org/1064133003/diff/1/ui/aura/window_unittest.cc File ui/aura/window_unittest.cc (right): https://codereview.chromium.org/1064133003/diff/1/ui/aura/window_unittest.cc#newcode34 ui/aura/window_unittest.cc:34: #include "ui/compositor/paint_recorder.h" Perhaps this include isn't necessary at ...
5 years, 8 months ago (2015-04-07 21:10:13 UTC) #2
danakj
https://codereview.chromium.org/1064133003/diff/1/ui/aura/window_unittest.cc File ui/aura/window_unittest.cc (right): https://codereview.chromium.org/1064133003/diff/1/ui/aura/window_unittest.cc#newcode34 ui/aura/window_unittest.cc:34: #include "ui/compositor/paint_recorder.h" On 2015/04/07 21:10:13, sadrul wrote: > Perhaps ...
5 years, 8 months ago (2015-04-07 21:11:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064133003/20001
5 years, 8 months ago (2015-04-07 21:12:46 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-07 22:32:40 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 22:33:33 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/533d7341af315b7c25bf0269314c8c2e50aa5ca5
Cr-Commit-Position: refs/heads/master@{#324137}

Powered by Google App Engine
This is Rietveld 408576698