content/browser/service_worker/service_worker_browsertest.cc - Issue 1063823005: Service Worker: Use more specific errors when StartWorker fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 1063823005: Service Worker: Use more specific errors when StartWorker fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update histograms.xml Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/embedded_worker_instance.cc ('k') | content/browser/service_worker/service_worker_context_wrapper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_browsertest.cc

diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc

index c030d8cf37edad00a870f6d7095d67195f097cfe..3a2393778817139b30274579ca82a15bf5768be4 100644

--- a/content/browser/service_worker/service_worker_browsertest.cc

+++ b/content/browser/service_worker/service_worker_browsertest.cc

@@ -694,7 +694,7 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest, StartNotFound) {

"/service_worker/nonexistent.js"));

// Start a worker for nonexistent URL.

- StartWorker(SERVICE_WORKER_ERROR_START_WORKER_FAILED);

+ StartWorker(SERVICE_WORKER_ERROR_NETWORK);

}

IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest, Install) {

@@ -773,7 +773,7 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest, TimeoutStartingWorker) {

base::TimeDelta::FromMilliseconds(100));

start_run_loop.Run();

- EXPECT_EQ(SERVICE_WORKER_ERROR_START_WORKER_FAILED, status);

+ EXPECT_EQ(SERVICE_WORKER_ERROR_TIMEOUT, status);

}

IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest, TimeoutWorkerInEvent) {