Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Unified Diff: content/browser/service_worker/service_worker_process_manager.cc

Issue 1063823005: Service Worker: Use more specific errors when StartWorker fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update histograms.xml Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_process_manager.cc
diff --git a/content/browser/service_worker/service_worker_process_manager.cc b/content/browser/service_worker/service_worker_process_manager.cc
index 7fa03a5132afef8a8c6ccaf9f97f6f92d05acdb5..c953129c8a4f18d3c8d887b05432bd7e521e4824 100644
--- a/content/browser/service_worker/service_worker_process_manager.cc
+++ b/content/browser/service_worker/service_worker_process_manager.cc
@@ -180,9 +180,8 @@ void ServiceWorkerProcessManager::AllocateWorkerProcess(
if (!browser_context_) {
// Shutdown has started.
BrowserThread::PostTask(
- BrowserThread::IO,
- FROM_HERE,
- base::Bind(callback, SERVICE_WORKER_ERROR_START_WORKER_FAILED, -1));
+ BrowserThread::IO, FROM_HERE,
+ base::Bind(callback, SERVICE_WORKER_ERROR_ABORT, -1));
return;
}
// No existing processes available; start a new one.
@@ -195,9 +194,8 @@ void ServiceWorkerProcessManager::AllocateWorkerProcess(
if (!rph->Init()) {
LOG(ERROR) << "Couldn't start a new process!";
BrowserThread::PostTask(
- BrowserThread::IO,
- FROM_HERE,
- base::Bind(callback, SERVICE_WORKER_ERROR_START_WORKER_FAILED, -1));
+ BrowserThread::IO, FROM_HERE,
+ base::Bind(callback, SERVICE_WORKER_ERROR_PROCESS_NOT_FOUND, -1));
return;
}

Powered by Google App Engine
This is Rietveld 408576698