Chromium side Implementation to expose aria properties - setsize & posinset

Chromium side Implementation to expose aria properties - setsize & posinset

This CL depends on https://codereview.chromium.org/1071483002/

BUG=474903
Committed: https://crrev.com/deec21d2f582eff12c78adac4d16ad54d7461066
Cr-Commit-Position: refs/heads/master@{#326463}

[shreeramk, 2015-04-08 12:00:53]

shreeram.k@samsung.com changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2015-04-09 06:31:22]

https://codereview.chromium.org/1063383005/diff/1/content/browser/accessibili...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/1063383005/diff/1/content/browser/accessibili...
content/browser/accessibility/browser_accessibility_win.cc:896: STDMETHODIMP
BrowserAccessibilityWin::get_groupPosition(
aria-posinset should also be exposed here.

https://codereview.chromium.org/1063383005/diff/1/content/browser/accessibili...
content/browser/accessibility/browser_accessibility_win.cc:3013: L"setsize:" +
base::IntToString16(GetParent()->PlatformChildCount()));
I think it'd be nicer if this logic was all done in Blink, so we don't have to
check the ARIA set size first and count the number of elements second - for each
platform.

[shreeramk, 2015-04-21 03:17:42]

PTAL. Thanks.

[dmazzoni, 2015-04-21 05:56:21]

Please make sure that you can dump these attributes on Mac and update the Mac
expectations too, thanks!

Could you also update BrowserAccessibilityAndroid::GetItemIndex and
BrowserAccessibilityAndroid::GetItemCount to use posinset/setsize when used in
allowed roles?

Note that I believe GetItemIndex is zero-based, not 1-based like posinset.

https://codereview.chromium.org/1063383005/diff/40001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_cocoa.mm (right):

https://codereview.chromium.org/1063383005/diff/40001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_cocoa.mm:1326:
@"AXARIAPosInSet",
I think we should only include these if they're relevant. It doesn't make sense
to expose posinset/setsize on all nodes.

I'd do it by checking
browserAccessibility_->HasIntAttribute(ui::AX_ATTR_SET_SIZE) and only add
support for these attributes if that attribute is present, kind of like the
other ones added below.

[shreeramk, 2015-04-21 06:27:04]

On 2015/04/21 05:56:21, dmazzoni wrote:
> Please make sure that you can dump these attributes on Mac and update the Mac
> expectations too, thanks!
> 
> Could you also update BrowserAccessibilityAndroid::GetItemIndex and
> BrowserAccessibilityAndroid::GetItemCount to use posinset/setsize when used in
> allowed roles?
> 

GetItemIndex can use posinset but GetItemCount can't use setsize.
Why? Because, setsize is calculated using child object and is exposed on child
node only.

[dmazzoni, 2015-04-21 22:44:25]

https://codereview.chromium.org/1063383005/diff/80001/content/test/data/acces...
File content/test/data/accessibility/aria/aria-setsize-expected-mac.txt (right):

https://codereview.chromium.org/1063383005/diff/80001/content/test/data/acces...
content/test/data/accessibility/aria/aria-setsize-expected-mac.txt:3:
++++AXStaticText AXRoleDescription='text' AXTitle='Item 1'
You should add AXARIASetSize, etc. here - it's probably just as simple as adding
them to accessibility_tree_formatter_mac.mm

[shreeramk, 2015-04-22 11:37:55]

PTAL.

Which bot should be used to test content_browsertest for android??

Thanks!!

[shreeramk, 2015-04-22 17:35:19]

On 2015/04/22 11:37:55, shreeramk wrote:
> PTAL.
> 
> Which bot should be used to test content_browsertest for android??
> 
> Thanks!!

Will update expectations for Mac n android tmtomorrow.

[dmazzoni, 2015-04-22 22:31:28]

I believe linux_android_dbg_ng and linux_android_rel_ng are the best
trybots to use for Android now, they should run everything. Let me know if
not.

On Wed, Apr 22, 2015 at 4:37 AM, <shreeram.k@samsung.com> wrote:

> PTAL.
>
> Which bot should be used to test content_browsertest for android??
>
> Thanks!!
>
>
> https://codereview.chromium.org/1063383005/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2015-04-22 22:32:19]

lgtm

[shreeramk, 2015-04-23 05:09:01]

The CQ bit was checked by shreeram.k@samsung.com

[shreeramk, 2015-04-23 05:09:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1063383005/#ps140001
(title: "updating expectations on android")

[commit-bot: I haz the power, 2015-04-23 05:09:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1063383005/140001

[commit-bot: I haz the power, 2015-04-23 06:02:35]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-04-23 06:03:30]

Patchset 8 (id:??) landed as
https://crrev.com/deec21d2f582eff12c78adac4d16ad54d7461066
Cr-Commit-Position: refs/heads/master@{#326463}