Chromium side Implementation to expose aria properties - setsize & posinset

content/browser/accessibility/browser_accessibility_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/accessibility/browser_accessibility_win.h"
 
 #include <UIAutomationClient.h>
 #include <UIAutomationCoreApi.h>
 
 #include "base/strings/string_number_conversions.h"
@@ skipping 875 matching lines @@
   } else {
     return E_INVALIDARG;
   }
 
   manager()->ScrollToPoint(*this, scroll_to);
   manager()->ToBrowserAccessibilityManagerWin()->TrackScrollingObject(this);
 
   return S_OK;
 }
 
 STDMETHODIMP BrowserAccessibilityWin::get_groupPosition(

[dmazzoni, 2015/04/09 06:31:22]

aria-posinset should also be exposed here.

     LONG* group_level,
     LONG* similar_items_in_group,
     LONG* position_in_group) {
   if (!instance_active())
     return E_FAIL;
 
   if (!group_level || !similar_items_in_group || !position_in_group)
     return E_INVALIDARG;
 
   if (GetRole() == ui::AX_ROLE_LIST_BOX_OPTION &&
@@ skipping 2092 matching lines @@
   StringAttributeToIA2(ui::AX_ATTR_HTML_TAG, "tag");
   StringAttributeToIA2(ui::AX_ATTR_ROLE, "xml-roles");
 
   // Expose "level" attribute for headings, trees, etc.
   IntAttributeToIA2(ui::AX_ATTR_HIERARCHICAL_LEVEL, "level");
 
   // Expose the set size and position in set for listbox options.
   if (GetRole() == ui::AX_ROLE_LIST_BOX_OPTION &&
       GetParent() &&
       GetParent()->GetRole() == ui::AX_ROLE_LIST_BOX) {
-    win_attributes_->ia2_attributes.push_back(
-        L"setsize:" + base::IntToString16(GetParent()->PlatformChildCount()));
-    win_attributes_->ia2_attributes.push_back(
-        L"setsize:" + base::IntToString16(GetIndexInParent() + 1));
+    if (HasIntAttribute(ui::AX_ATTR_SET_SIZE)){
+      IntAttributeToIA2(ui::AX_ATTR_SET_SIZE, "setsize");
+    } else {
+      win_attributes_->ia2_attributes.push_back(
+          L"setsize:" + base::IntToString16(GetParent()->PlatformChildCount()));

[dmazzoni, 2015/04/09 06:31:22]

I think it'd be nicer if this logic was all done in Blink, so we don't have to
check the ARIA set size first and count the number of elements second - for each
platform.

+    }
+
+    if (HasIntAttribute(ui::AX_ATTR_POS_IN_SET)){
+      IntAttributeToIA2(ui::AX_ATTR_POS_IN_SET, "posinset");
+    } else {
+      win_attributes_->ia2_attributes.push_back(
+          L"posinset:" + base::IntToString16(GetIndexInParent() + 1));
+    }
   }
 
   if (ia_role() == ROLE_SYSTEM_CHECKBUTTON ||
       ia_role() == ROLE_SYSTEM_RADIOBUTTON ||
       ia2_role() == IA2_ROLE_CHECK_MENU_ITEM ||
       ia2_role() == IA2_ROLE_RADIO_MENU_ITEM ||
       ia2_role() == IA2_ROLE_TOGGLE_BUTTON) {
     win_attributes_->ia2_attributes.push_back(L"checkable:true");
   }
 
@@ skipping 1121 matching lines @@
     ia2_role = ia_role;
 
   win_attributes_->ia_role = ia_role;
   win_attributes_->ia_state = ia_state;
   win_attributes_->role_name = role_name;
   win_attributes_->ia2_role = ia2_role;
   win_attributes_->ia2_state = ia2_state;
 }
 
 }  // namespace content