content/browser/accessibility/browser_accessibility_android.cc - Issue 1063383005: Chromium side Implementation to expose aria properties - setsize & posinset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_android.cc

Issue 1063383005: Chromium side Implementation to expose aria properties - setsize & posinset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updating expectations on android Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/accessibility_tree_formatter_mac.mm ('k') | content/browser/accessibility/browser_accessibility_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_android.cc

diff --git a/content/browser/accessibility/browser_accessibility_android.cc b/content/browser/accessibility/browser_accessibility_android.cc

index 9bfd68a343175d8505db9081a250d982a5d68013..dcb723fc5e6b15fb0cf5761986f5aecaf6847c9e 100644

--- a/content/browser/accessibility/browser_accessibility_android.cc

+++ b/content/browser/accessibility/browser_accessibility_android.cc

@@ -445,7 +445,7 @@ int BrowserAccessibilityAndroid::GetItemIndex() const {

case ui::AX_ROLE_LIST_ITEM:

case ui::AX_ROLE_LIST_BOX_OPTION:

case ui::AX_ROLE_TREE_ITEM:

- index = GetIndexInParent();

+ index = GetIntAttribute(ui::AX_ATTR_POS_IN_SET) - 1;

break;

case ui::AX_ROLE_SLIDER:

case ui::AX_ROLE_PROGRESS_INDICATOR: {