Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1063313002: Replace "computer" with "device" in permission warning strings. (Closed)

Created:
5 years, 8 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 8 months ago
Reviewers:
meacer
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace "computer" with "device" in permission warning strings. Make these extension permission warning strings "Internet of Things" friendly be replacing the word "computer" with "device." Committed: https://crrev.com/c718ad86bce40f233a8ba43d30150e6fe7dddac4 Cr-Commit-Position: refs/heads/master@{#324304}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : devices -> device #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M chrome/browser/extensions/permission_message_combinations_unittest.cc View 16 chunks +16 lines, -16 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M extensions/extensions_strings.grd View 1 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Reilly Grant (use Gerrit)
Please take a look Mustafa since you suggested it.
5 years, 8 months ago (2015-04-08 19:07:18 UTC) #3
meacer
LGTM, thanks Reilly. https://codereview.chromium.org/1063313002/diff/20001/extensions/extensions_strings.grd File extensions/extensions_strings.grd (right): https://codereview.chromium.org/1063313002/diff/20001/extensions/extensions_strings.grd#newcode333 extensions/extensions_strings.grd:333: <message name="IDS_EXTENSION_PROMPT_WARNING_SOCKET_SPECIFIC_HOST" desc="Permission string for access ...
5 years, 8 months ago (2015-04-08 19:14:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063313002/40001
5 years, 8 months ago (2015-04-08 19:28:09 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 8 months ago (2015-04-08 23:10:09 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 23:11:48 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c718ad86bce40f233a8ba43d30150e6fe7dddac4
Cr-Commit-Position: refs/heads/master@{#324304}

Powered by Google App Engine
This is Rietveld 408576698