Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 1063313002: Replace "computer" with "device" in permission warning strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: devices -> device Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/permission_set_unittest.cc
diff --git a/chrome/common/extensions/permissions/permission_set_unittest.cc b/chrome/common/extensions/permissions/permission_set_unittest.cc
index 581855cba6be733f45a32bab6b7130f3e2287c95..f212652ab25e7d784d054d97d75e0a6000f27ea5 100644
--- a/chrome/common/extensions/permissions/permission_set_unittest.cc
+++ b/chrome/common/extensions/permissions/permission_set_unittest.cc
@@ -1270,7 +1270,7 @@ TEST(PermissionsTest, GetWarningMessages_Socket_AnyHost) {
extension->permissions_data()->HasAPIPermission(APIPermission::kSocket));
EXPECT_TRUE(VerifyOnePermissionMessage(
extension->permissions_data(),
- "Exchange data with any computer on the local network or internet"));
+ "Exchange data with any device on the local network or internet"));
}
TEST(PermissionsTest, GetWarningMessages_Socket_OneDomainTwoHostnames) {
@@ -1288,8 +1288,8 @@ TEST(PermissionsTest, GetWarningMessages_Socket_OneDomainTwoHostnames) {
// order in the manifest file.
EXPECT_TRUE(VerifyTwoPermissionMessages(
extension->permissions_data(),
- "Exchange data with any computer in the domain example.org",
- "Exchange data with the computers named: "
+ "Exchange data with any device in the domain example.org",
+ "Exchange data with the devices named: "
"b\xC3\xA5r.example.com foo.example.com",
// "\xC3\xA5" = UTF-8 for lowercase A with ring above
true));
@@ -1309,9 +1309,9 @@ TEST(PermissionsTest, GetWarningMessages_Socket_TwoDomainsOneHostname) {
// in alphabetical order regardless of the order in the manifest file.
EXPECT_TRUE(VerifyTwoPermissionMessages(
extension->permissions_data(),
- "Exchange data with any computer in the domains: "
+ "Exchange data with any device in the domains: "
"example.com foo.example.org",
- "Exchange data with the computer named bar.example.org", true));
+ "Exchange data with the device named bar.example.org", true));
}
// Since platform apps always use isolated storage, they can't (silently)
« no previous file with comments | « chrome/browser/extensions/permission_message_combinations_unittest.cc ('k') | extensions/extensions_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698