Issue 1063263002: Remove 'email', 'password' and 'private_key_file' properties of Rietveld class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1063263002: Remove 'email', 'password' and 'private_key_file' properties of Rietveld class. (Closed)

Created:
5 years, 8 months ago by Vadim Sh.

Modified:
5 years, 8 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Target Ref:
refs/heads/master

Project:
tools

Visibility:
Public.

More Reviews

Description

Remove 'email', 'password' and 'private_key_file' properties of Rietveld class. They were used by CQ code, but CQ forked relevant parts of depot_tools already and no longer uses this code. These properties are unused now (as far as I can tell searching through code). They expose auth implementation details that better to be hidden (since they will change with OAuth2 adoption). R=maruel@chromium.org BUG=356813 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294707

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -15 lines)			Patch
	M	rietveld.py	View		3 chunks	+1 line, -15 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063263002/1

5 years, 8 months ago (2015-04-07 22:41:06 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-07 22:44:09 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294707

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages