Remove 'email', 'password' and 'private_key_file' properties of Rietveld class.

rietveld.py

 # coding: utf-8
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Defines class Rietveld to easily access a rietveld instance.
 
 Security implications:
 
 The following hypothesis are made:
 - Rietveld enforces:
@@ skipping 21 matching lines @@
 
 # Appengine replies with 302 when authentication fails (sigh.)
 oa2client.REFRESH_STATUS_CODES.append(302)
 upload.LOGGER.setLevel(logging.WARNING)  # pylint: disable=E1103
 
 
 class Rietveld(object):
   """Accesses rietveld."""
   def __init__(self, url, email, password, extra_headers=None, maxtries=None):
     self.url = url.rstrip('/')
-    # Email and password are accessed by commit queue, keep them.
-    self.email = email
-    self.password = password
+
     # TODO(maruel): It's not awesome but maybe necessary to retrieve the value.
     # It happens when the presubmit check is ran out of process, the cookie
     # needed to be recreated from the credentials. Instead, it should pass the
     # email and the cookie.
     if email and password:
       get_creds = lambda: (email, password)
       self.rpc_server = upload.HttpRpcServer(
             self.url,
             get_creds,
             extra_headers=extra_headers or {})
@@ skipping 517 matching lines @@
   # The parent__init__ is not called on purpose.
   # pylint: disable=W0231
   def __init__(self,
                url,
                client_email,
                client_private_key_file,
                private_key_password=None,
                extra_headers=None,
                maxtries=None):
 
-    # These attributes are accessed by commit queue. Keep them.
-    self.email = client_email
-    self.private_key_file = client_private_key_file
-
     if private_key_password is None:  # '' means 'empty password'
       private_key_password = 'notasecret'
 
     self.url = url.rstrip('/')
     bot_url = self.url + '/bots'
 
     with open(client_private_key_file, 'rb') as f:
       client_private_key = f.read()
     logging.info('Using OAuth login: %s' % client_email)
     self.rpc_server = OAuthRpcServer(bot_url,
@@ skipping 75 matching lines @@
 
   @classmethod
   def _get_local_changes(cls, issue):
     """Returns dictionary of local changes for |issue|, if any."""
     return cls._local_changes.get(issue, {})
 
   @property
   def url(self):
     return self._rietveld.url
 
-  @property
-  def email(self):
-    return self._rietveld.email
-
-  @property
-  def password(self):
-    return self._rietveld.password
-
   def get_pending_issues(self):
     pending_issues = self._rietveld.get_pending_issues()
 
     # Filter out issues we've closed or unchecked the commit checkbox.
     return [issue for issue in pending_issues
             if not self._get_local_changes(issue).get('closed', False) and
             self._get_local_changes(issue).get('commit', True)]
 
   def close_issue(self, issue):  # pylint:disable=R0201
     logging.info('ReadOnlyRietveld: closing issue %d' % issue)
@@ skipping 30 matching lines @@
       self, issue, patchset, reason, clobber, revision, builders_and_tests,
       master=None, category='cq'):
     logging.info('ReadOnlyRietveld: triggering try jobs %r for issue %d' %
         (builders_and_tests, issue))
 
   def trigger_distributed_try_jobs(  # pylint:disable=R0201
       self, issue, patchset, reason, clobber, revision, masters,
       category='cq'):
     logging.info('ReadOnlyRietveld: triggering try jobs %r for issue %d' %
         (masters, issue))