Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: rietveld.py

Issue 1063263002: Remove 'email', 'password' and 'private_key_file' properties of Rietveld class. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: rietveld.py
diff --git a/rietveld.py b/rietveld.py
index e36d2cd3a925b8d0c7ba4a8a8fc79268431f6f05..f3bcd718d318e5f95f46c327c8a4d6ebe85686ac 100644
--- a/rietveld.py
+++ b/rietveld.py
@@ -39,9 +39,7 @@ class Rietveld(object):
"""Accesses rietveld."""
def __init__(self, url, email, password, extra_headers=None, maxtries=None):
self.url = url.rstrip('/')
- # Email and password are accessed by commit queue, keep them.
- self.email = email
- self.password = password
+
# TODO(maruel): It's not awesome but maybe necessary to retrieve the value.
# It happens when the presubmit check is ran out of process, the cookie
# needed to be recreated from the credentials. Instead, it should pass the
@@ -579,10 +577,6 @@ class JwtOAuth2Rietveld(Rietveld):
extra_headers=None,
maxtries=None):
- # These attributes are accessed by commit queue. Keep them.
- self.email = client_email
- self.private_key_file = client_private_key_file
-
if private_key_password is None: # '' means 'empty password'
private_key_password = 'notasecret'
@@ -678,14 +672,6 @@ class ReadOnlyRietveld(object):
def url(self):
return self._rietveld.url
- @property
- def email(self):
- return self._rietveld.email
-
- @property
- def password(self):
- return self._rietveld.password
-
def get_pending_issues(self):
pending_issues = self._rietveld.get_pending_issues()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698