Fix AdjustBoundsToEnsureWindowVisibility to work with non primary display bounds

Fix AdjustBoundsToEnsureWindowVisibility to work with non primary display bounds
 This was asssuming that the visibile area has 0,0 origin.

Move the code to ensure minimum visibility when added, from
WorkspaceLayoutManager to DragWindowResizer.

BUG=none
TEST=WindowUtilTest.AdjustBoundsToEnsureWindowVisibility.
 This also fixes the test that was failing.
TBR=oshima@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243986

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244131

[oshima, 2013-12-19 22:37:54]

flackr@, can you review this?

[oshima, 2013-12-19 22:46:48]

back to varkha@chromium.org. not urgent. please review when you're back from
vacation.

[varkha, 2014-01-02 22:42:42]

https://codereview.chromium.org/106303005/diff/70001/ash/display/screen_posit...
File ash/display/screen_position_controller.cc (right):

https://codereview.chromium.org/106303005/diff/70001/ash/display/screen_posit...
ash/display/screen_position_controller.cc:204: window->SetBounds(new_bounds);
I tried this in patch #1 of my CL
(https://codereview.chromium.org/57963003/#ps30001) and I think I had to protect
the popup windows from this early set bounds. Not sure if this was breaking some
tests.

[oshima, 2014-01-08 02:16:10]

https://codereview.chromium.org/106303005/diff/70001/ash/display/screen_posit...
File ash/display/screen_position_controller.cc (right):

https://codereview.chromium.org/106303005/diff/70001/ash/display/screen_posit...
ash/display/screen_position_controller.cc:204: window->SetBounds(new_bounds);
On 2014/01/02 22:42:42, varkha wrote:
> I tried this in patch #1 of my CL
> (https://codereview.chromium.org/57963003/#ps30001) and I think I had to
protect
> the popup windows from this early set bounds. Not sure if this was breaking
some
> tests.

What was broken? Drag code overrides the bounds after reparent.

[oshima, 2014-01-08 19:30:21]

On 2014/01/02 22:42:42, varkha wrote:
>
https://codereview.chromium.org/106303005/diff/70001/ash/display/screen_posit...
> File ash/display/screen_position_controller.cc (right):
> 
>
https://codereview.chromium.org/106303005/diff/70001/ash/display/screen_posit...
> ash/display/screen_position_controller.cc:204: window->SetBounds(new_bounds);
> I tried this in patch #1 of my CL
> (https://codereview.chromium.org/57963003/#ps30001) and I think I had to
protect
> the popup windows from this early set bounds. Not sure if this was breaking
some
> tests.

Looking at the code again, the original CL didn't work because it skipped the
extra set bounds.

if (!popup)
  return;

This is why I added the comment and didn't return. This code should work and I
will address the issue separately.

I also tweaked a few tests to pass with docked windows.

[varkha, 2014-01-09 05:21:22]

LGTM.

https://codereview.chromium.org/106303005/diff/150001/ash/wm/workspace/worksp...
File ash/wm/workspace/workspace_layout_manager.cc (right):

https://codereview.chromium.org/106303005/diff/150001/ash/wm/workspace/worksp...
ash/wm/workspace/workspace_layout_manager.cc:268: 
nit: Could early return before line 260.

[oshima, 2014-01-09 18:07:19]

https://codereview.chromium.org/106303005/diff/150001/ash/wm/workspace/worksp...
File ash/wm/workspace/workspace_layout_manager.cc (right):

https://codereview.chromium.org/106303005/diff/150001/ash/wm/workspace/worksp...
ash/wm/workspace/workspace_layout_manager.cc:268: 
On 2014/01/09 05:21:22, varkha wrote:
> nit: Could early return before line 260.

done. consolidated all three to one if.

[commit-bot: I haz the power, 2014-01-09 18:09:55]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[oshima, 2014-01-09 18:17:58]

On 2014/01/09 18:09:55, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a lowly provisional committer, _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

TBR'ing to myself as varkha's committer status has already been approved.

[commit-bot: I haz the power, 2014-01-09 18:18:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/106303005/290001

[commit-bot: I haz the power, 2014-01-09 21:58:25]

Change committed as 243986

[oshima, 2014-01-10 04:54:02]

https://codereview.chromium.org/106303005/diff/290001/ash/display/screen_posi...
File ash/display/screen_position_controller.cc (right):

https://codereview.chromium.org/106303005/diff/290001/ash/display/screen_posi...
ash/display/screen_position_controller.cc:197:
window->parent()->RemoveChild(window);
I had to remove this because this was causing problem in capture window.
Everything still works as it's reparented immediately after SetBounds. PTAL.

[commit-bot: I haz the power, 2014-01-10 04:55:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/106303005/550002

[varkha, 2014-01-10 05:44:02]

https://codereview.chromium.org/106303005/diff/290001/ash/display/screen_posi...
File ash/display/screen_position_controller.cc (right):

https://codereview.chromium.org/106303005/diff/290001/ash/display/screen_posi...
ash/display/screen_position_controller.cc:197:
window->parent()->RemoveChild(window);
On 2014/01/10 04:54:02, oshima wrote:
> I had to remove this because this was causing problem in capture window.
> Everything still works as it's reparented immediately after SetBounds. PTAL.

Still lgtm.

[commit-bot: I haz the power, 2014-01-10 07:29:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/106303005/550002

[commit-bot: I haz the power, 2014-01-10 09:00:49]

Change committed as 244131