Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1062863006: Remove checks in fxge/{apple,win32,skia,dib} now that FX_NEW cant return 0 (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove checks in fxge/{apple,win32,skia,dib} now that FX_NEW cant return 0 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/3f754d483e257f0d373be28a64b58620b4e0953f

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix missing |new| typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -150 lines) Patch
M core/src/fxge/apple/fx_mac_imp.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M core/src/fxge/apple/fx_quartz_device.cpp View 1 3 chunks +3 lines, -12 lines 0 comments Download
M core/src/fxge/dib/fx_dib_convert.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M core/src/fxge/dib/fx_dib_engine.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M core/src/fxge/dib/fx_dib_main.cpp View 11 chunks +11 lines, -44 lines 0 comments Download
M core/src/fxge/dib/fx_dib_transform.cpp View 2 chunks +2 lines, -8 lines 0 comments Download
M core/src/fxge/skia/fx_skia_device.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M core/src/fxge/win32/fx_win32_device.cpp View 4 chunks +7 lines, -19 lines 0 comments Download
M core/src/fxge/win32/fx_win32_dib.cpp View 4 chunks +4 lines, -18 lines 0 comments Download
M core/src/fxge/win32/fx_win32_dwrite.cpp View 3 chunks +3 lines, -10 lines 0 comments Download
M core/src/fxge/win32/fx_win32_gdipext.cpp View 2 chunks +2 lines, -8 lines 0 comments Download
M core/src/fxge/win32/fx_win32_print.cpp View 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Tom Sepez
Lei, for review.
5 years, 8 months ago (2015-04-15 19:25:56 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1062863006/diff/1/core/src/fxge/win32/fx_win32_print.cpp File core/src/fxge/win32/fx_win32_print.cpp (right): https://codereview.chromium.org/1062863006/diff/1/core/src/fxge/win32/fx_win32_print.cpp#newcode315 core/src/fxge/win32/fx_win32_print.cpp:315: return TRUE; This always returns true now but ...
5 years, 8 months ago (2015-04-16 08:04:10 UTC) #3
Tom Sepez
> https://codereview.chromium.org/1062863006/diff/1/core/src/fxge/win32/fx_win32_print.cpp#newcode315 > core/src/fxge/win32/fx_win32_print.cpp:315: return TRUE; > This always returns true now but we can ...
5 years, 8 months ago (2015-04-16 15:38:11 UTC) #4
Tom Sepez
5 years, 8 months ago (2015-04-16 16:13:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3f754d483e257f0d373be28a64b58620b4e0953f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698