Remove checks in fxge/{apple,win32,skia,dib} now that FX_NEW cant return 0

core/src/fxge/win32/fx_win32_print.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fxge/fx_ge.h"
 #if _FX_OS_ == _FX_WIN32_DESKTOP_ || _FX_OS_ == _FX_WIN64_
 #include <windows.h>
 #include "../../../include/fxge/fx_ge_win32.h"
@@ skipping 125 matching lines @@
     src2result.a = adjusted_matrix.a / pSrcBitmap->GetWidth();
     src2result.b = adjusted_matrix.b / pSrcBitmap->GetWidth();
     src2result.c = -adjusted_matrix.c / pSrcBitmap->GetHeight();
     src2result.d = -adjusted_matrix.d / pSrcBitmap->GetHeight();
     src2result.TranslateI(-result_rect.left, -result_rect.top);
     CFX_AffineMatrix result2src;
     result2src.SetReverse(src2result);
     CPDF_FixedMatrix result2src_fix(result2src, 8);
     int result_width = result_rect.Width();
     int result_height = result_rect.Height();
-    CFX_DIBitmap* pTempBitmap = FX_NEW CFX_DIBitmap;
-    if (!pTempBitmap) {
-        if (pSrcBitmap != src_bitmap) {
-            delete pSrcBitmap;
-        }
-        return NULL;
-    }
+    CFX_DIBitmap* pTempBitmap = new CFX_DIBitmap;
     if (!pTempBitmap->Create(result_width, result_height, pSrc->GetFormat())) {
         delete pTempBitmap;
         if (pSrcBitmap != src_bitmap) {
             delete pSrcBitmap;
         }
         return NULL;
     }
     pTempBitmap->CopyPalette(pSrc->GetPalette());
     FX_LPBYTE dest_buf = pTempBitmap->GetBuffer();
     int dest_pitch = pTempBitmap->GetPitch();
@@ skipping 121 matching lines @@
     }
 }
 FX_BOOL CPSPrinterDriver::Init(HDC hDC, int pslevel, FX_BOOL bCmykOutput)
 {
     m_hDC = hDC;
     m_HorzSize = ::GetDeviceCaps(m_hDC, HORZSIZE);
     m_VertSize = ::GetDeviceCaps(m_hDC, VERTSIZE);
     m_Width = ::GetDeviceCaps(m_hDC, HORZRES);
     m_Height = ::GetDeviceCaps(m_hDC, VERTRES);
     m_nBitsPerPixel = ::GetDeviceCaps(m_hDC, BITSPIXEL);
-    m_pPSOutput = FX_NEW CPSOutput(hDC);
-    if (!m_pPSOutput) {
-        return FALSE;
-    }
+    m_pPSOutput = new CPSOutput(hDC);
     ((CPSOutput*)m_pPSOutput)->Init();
     m_PSRenderer.Init(m_pPSOutput, pslevel, m_Width, m_Height, bCmykOutput);
     m_bCmykOutput = bCmykOutput;
     HRGN hRgn = ::CreateRectRgn(0, 0, 1, 1);
     int ret = ::GetClipRgn(hDC, hRgn);
     if (ret == 1) {
         ret = ::GetRegionData(hRgn, 0, NULL);
         if (ret) {
             RGNDATA* pData = (RGNDATA*)FX_Alloc(FX_BYTE, ret);
             if (!pData) {
                 return FALSE;
             }
             ret = ::GetRegionData(hRgn, ret, pData);
             if (ret) {
                 CFX_PathData path;
                 path.AllocPointCount(pData->rdh.nCount * 5);
                 for (FX_DWORD i = 0; i < pData->rdh.nCount; i ++) {
                     RECT* pRect = (RECT*)(pData->Buffer + pData->rdh.nRgnSize * i);
                     path.AppendRect((FX_FLOAT)pRect->left, (FX_FLOAT)pRect->bottom, (FX_FLOAT)pRect->right, (FX_FLOAT)pRect->top);
                 }
                 m_PSRenderer.SetClip_PathFill(&path, NULL, FXFILL_WINDING);
             }
             FX_Free(pData);
         }
     }
     ::DeleteObject(hRgn);
     return TRUE;

[Lei Zhang, 2015/04/16 08:04:10]

This always returns true now but we can make another pass and deal with them.

 }
 int CPSPrinterDriver::GetDeviceCaps(int caps_id)
 {
     switch (caps_id) {
         case FXDC_DEVICE_CLASS:
             return FXDC_PRINTER;
         case FXDC_PIXEL_WIDTH:
             return m_Width;
         case FXDC_PIXEL_HEIGHT:
             return m_Height;
@@ skipping 82 matching lines @@
     handle = NULL;
     return m_PSRenderer.DrawDIBits(pBitmap, color, pMatrix, render_flags, alpha_flag, pIccTransform);
 }
 FX_BOOL CPSPrinterDriver::DrawDeviceText(int nChars, const FXTEXT_CHARPOS* pCharPos, CFX_Font* pFont,
         CFX_FontCache* pCache, const CFX_AffineMatrix* pObject2Device, FX_FLOAT font_size, FX_DWORD color,
         int alpha_flag, void* pIccTransform)
 {
     return m_PSRenderer.DrawText(nChars, pCharPos, pFont, pCache, pObject2Device, font_size, color, alpha_flag, pIccTransform);
 }
 #endif