Remove checks in fxge/{apple,win32,skia,dib} now that FX_NEW cant return 0

core/src/fxge/skia/fx_skia_device.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "../../../include/fxge/fx_ge.h"
 //#define _SKIA_SUPPORT_
 #if defined(_SKIA_SUPPORT_)
 #include "../../../include/fxcodec/fx_codec.h"
 
 
@@ skipping 219 matching lines @@
                 spaint.getFillPath(path_data, dstPathData);
                 SkMatrix smatrix; 
                 smatrix.setAll(pObject2Device->a, pObject2Device->c, pObject2Device->e, pObject2Device->b, pObject2Device->d, pObject2Device->f, 0, 0, 1);
                 dstPathData->transform(smatrix);
                 FX_Free(intervals);
         }
 }
 
 CFX_SkiaDeviceDriver::CFX_SkiaDeviceDriver(CFX_DIBitmap* pBitmap, int dither_bits, FX_BOOL bRgbByteOrder, CFX_DIBitmap* pOriDevice, FX_BOOL bGroupKnockout)
 {
-        m_pAggDriver = FX_NEW CFX_AggDeviceDriver(pBitmap, dither_bits, bRgbByteOrder, pOriDevice, bGroupKnockout);
+        m_pAggDriver = new CFX_AggDeviceDriver(pBitmap, dither_bits, bRgbByteOrder, pOriDevice, bGroupKnockout);
 }
 CFX_SkiaDeviceDriver::~CFX_SkiaDeviceDriver()
 {
         if (m_pAggDriver) delete m_pAggDriver;
 }
 FX_BOOL CFX_SkiaDeviceDriver::DrawDeviceText(int nChars, const FXTEXT_CHARPOS* pCharPos, CFX_Font* pFont,
                 CFX_FontCache* pCache, const CFX_AffineMatrix* pObject2Device, FX_FIXFLOAT font_size, FX_DWORD color, 
                 int alpha_flag, void* pIccTransform)
 {
         return m_pAggDriver->DrawDeviceText(nChars, pCharPos, pFont,pCache, pObject2Device, font_size, color, 
@@ skipping 42 matching lines @@
         // Finally, we have got the mask that we need, intersect with current clip region
         m_pAggDriver->m_pClipRgn->IntersectMaskF(clip_box.fLeft, clip_box.fTop, mask);
 
 }
 FX_BOOL CFX_SkiaDeviceDriver::SetClip_PathFill(const CFX_PathData* pPathData,   // path info
                                                 const CFX_AffineMatrix* pObject2Device, // optional transformation
                                                 int fill_mode   // fill mode, WINDING or ALTERNATE
                                                 )
 {
         if (m_pAggDriver->m_pClipRgn == NULL)
-                m_pAggDriver->m_pClipRgn = FX_NEW CFX_ClipRgn(GetDeviceCaps(FXDC_PIXEL_WIDTH), GetDeviceCaps(FXDC_PIXEL_HEIGHT));
+                m_pAggDriver->m_pClipRgn = new CFX_ClipRgn(GetDeviceCaps(FXDC_PIXEL_WIDTH), GetDeviceCaps(FXDC_PIXEL_HEIGHT));
 
         if (pPathData->GetPointCount() == 5 || pPathData->GetPointCount() == 4) {
                 CFX_FloatRect rectf;
                 if (pPathData->IsRect(pObject2Device, &rectf)) {
                         rectf.Intersect(CFX_FloatRect(0, 0, (FX_FIXFLOAT)GetDeviceCaps(FXDC_PIXEL_WIDTH), (FX_FIXFLOAT)GetDeviceCaps(FXDC_PIXEL_HEIGHT)));
                         FX_RECT rect = rectf.GetOutterRect();
                         m_pAggDriver->m_pClipRgn->IntersectRect(rect);
                         return TRUE;
                 }
         }
@@ skipping 11 matching lines @@
 
         return TRUE;
 }
 
 FX_BOOL CFX_SkiaDeviceDriver::SetClip_PathStroke(const CFX_PathData* pPathData, // path info
                                                 const CFX_AffineMatrix* pObject2Device, // optional transformation
                                                 const CFX_GraphStateData* pGraphState   // graphic state, for pen attributes
                                         )
 {
         if (m_pAggDriver->m_pClipRgn == NULL)
-                m_pAggDriver->m_pClipRgn = FX_NEW CFX_ClipRgn(GetDeviceCaps(FXDC_PIXEL_WIDTH), GetDeviceCaps(FXDC_PIXEL_HEIGHT));
+                m_pAggDriver->m_pClipRgn = new CFX_ClipRgn(GetDeviceCaps(FXDC_PIXEL_WIDTH), GetDeviceCaps(FXDC_PIXEL_HEIGHT));
 
         // build path data
         CSkia_PathData path_data;
         path_data.BuildPath(pPathData, NULL);
         path_data.m_PathData.setFillType(SkPath::kWinding_FillType);
 
         SkPaint spaint;
         spaint.setColor(0xffffffff);
         spaint.setStyle(SkPaint::kStroke_Style);
         spaint.setAntiAlias(TRUE);
@@ skipping 152 matching lines @@
 CFX_SkiaDevice::CFX_SkiaDevice()
 {
         m_bOwnedBitmap = FALSE;
 }
 
 FX_BOOL CFX_SkiaDevice::Attach(CFX_DIBitmap* pBitmap, int dither_bits, FX_BOOL bRgbByteOrder, CFX_DIBitmap* pOriDevice, FX_BOOL bGroupKnockout)
 {
         if (pBitmap == NULL) 
                 return FALSE;
         SetBitmap(pBitmap);
-        CFX_SkiaDeviceDriver* pDriver = FX_NEW CFX_SkiaDeviceDriver(pBitmap, dither_bits, bRgbByteOrder, pOriDevice, bGroupKnockout);
+        CFX_SkiaDeviceDriver* pDriver = new CFX_SkiaDeviceDriver(pBitmap, dither_bits, bRgbByteOrder, pOriDevice, bGroupKnockout);
         SetDeviceDriver(pDriver);
         return TRUE;
 }
 
 FX_BOOL CFX_SkiaDevice::Create(int width, int height, FXDIB_Format format, int dither_bits, CFX_DIBitmap* pOriDevice)
 {
         m_bOwnedBitmap = TRUE;
-        CFX_DIBitmap* pBitmap = FX_NEW CFX_DIBitmap;
+        CFX_DIBitmap* pBitmap = new CFX_DIBitmap;
         if (!pBitmap->Create(width, height, format)) {
                 delete pBitmap;
                 return FALSE;
         } 
         SetBitmap(pBitmap);
-        CFX_SkiaDeviceDriver* pDriver =  FX_NEW CFX_SkiaDeviceDriver(pBitmap, dither_bits, FALSE, pOriDevice, FALSE);
+        CFX_SkiaDeviceDriver* pDriver =  new CFX_SkiaDeviceDriver(pBitmap, dither_bits, FALSE, pOriDevice, FALSE);
         SetDeviceDriver(pDriver);
         return TRUE;
 }
 CFX_SkiaDevice::~CFX_SkiaDevice()
 {
         if (m_bOwnedBitmap && GetBitmap()) delete GetBitmap();
 }
 
-#endif
+#endif