Add gfx::GpuMemoryBuffer::YUV_420 and GpuMemoryBufferImplSharedMemory support

We started redesigning GpuMemoryBuffer interface to handle multiple buffers [0].

[0] https://codereview.chromium.org/1024113003/#ps200001

In this CL:

- I added a new format gfx::GpuMemoryBuffer::YUV_420
- Implemented helper functions to use with it on GpuMemoryBufferImpl.
- I added support in GpuMemoryBufferImplSharedMemory and GpuMemoryBufferFactorySharedMemory
- I added { gfx::GpuMemoryBuffer::YUV_420, gfx::GpuMemoryBuffer::MAP } as a supported config for testing
- I added support for multi plane in test implementations: test_gpu_memory_buffer_manager, gl_manager, gpu_memory_buffer_impl_unittest

The future steps are:
- Add a new GL_* internalformat corresponding to YUV_420
- Implement support for YUV_420 in GpuMemoryBufferFactoryOzoneNativeBuffer, GLImageLinuxDMABuffer and SurfaceFactoryOzone
- Expose file descriptors for gfx::GpuMemoryBuffer::YUV_420 via Map() or GpuMemoryBufferHandle struct
  Check usage of gbm_bo_get_fd() at the lowest gbmbuffer level
- Add support in GLImageSharedMemory and GLImageMemory through Bind functions
- Look for possible use cases of multiple buffers on Android, Mac, and Win platforms

BUG=439520
TEST=content_unittests  --gtest_filter=GpuMemoryBufferImplTests.*
content_unittests  --gtest_filter=GpuMemoryBufferFactoryTest.*
gl_tests --gtest_filter=GpuMemoryBufferTest*

Committed: https://crrev.com/607ed17ba5d0d1c67901ecc7160db660f08bd831
Cr-Commit-Position: refs/heads/master@{#324190}

[emircan, 2015-04-07 16:16:50]

Patchset #1 (id:1) has been deleted

[emircan, 2015-04-07 16:26:20]

Patchset #1 (id:20001) has been deleted

[emircan, 2015-04-07 17:04:49]

Patchset #1 (id:40001) has been deleted

[emircan, 2015-04-07 17:16:02]

emircan@chromium.org changed reviewers:
+ mcasas@chromium.org, reveman@chromium.org

[emircan, 2015-04-07 17:16:21]

Please take a look.

[reveman, 2015-04-07 19:03:25]

this looks great! mostly nits and a possible overflow issue

https://codereview.chromium.org/1062853002/diff/60001/cc/test/test_gpu_memory...
File cc/test/test_gpu_memory_buffer_manager.cc (right):

https://codereview.chromium.org/1062853002/diff/60001/cc/test/test_gpu_memory...
cc/test/test_gpu_memory_buffer_manager.cc:8: #include
"base/memory/scoped_vector.h"
nit: you don't need this anymore

https://codereview.chromium.org/1062853002/diff/60001/cc/test/test_gpu_memory...
cc/test/test_gpu_memory_buffer_manager.cc:109: if (num_planes > 1) {
nit: this if statement is not necessary, the for loop condition expression is
enough.

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
File content/common/gpu/client/gpu_memory_buffer_impl.cc (right):

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
content/common/gpu/client/gpu_memory_buffer_impl.cc:173: stride_in_bytes *
(size.height() / SubsamplingFactor(format, i));
This multiplication can overflow. You need another CheckedNumeric here to
protect against it.

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
File content/common/gpu/client/gpu_memory_buffer_impl.h (right):

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
content/common/gpu/client/gpu_memory_buffer_impl.h:54: static bool
TotalBufferSizeInBytes(const gfx::Size& size,
nit: not sure you need the "Total" prefix, BufferSizeInBytes seems sufficient
but feel free to keep it if you think it's useful

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
content/common/gpu/client/gpu_memory_buffer_impl.h:56: size_t*
total_size_in_bytes);
remove "total_" prefix here too if you decide to remove it above

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
File content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc (right):

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc:142: if
(size.width() % factor != 0 || size.height() % factor != 0)
nit: style guide prefers "size.width() % factor || size.height() % factor"

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc:159: if
(num_planes > 1) {
nit: this if statement is not necessary, the for loop condition expression is
enough.

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc:160: size_t
stride_in_bytes = 0;
nit: you can move this into the for-loop scope

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc:162: if
(!StrideInBytes(size_.width(), format_, i, &stride_in_bytes))
nit: it's better to DCHECK here if this fails just like ::GetStride.

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc:179: size_t
stride_in_bytes = 0;
nit: you can move this into the for-loop scope

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
File content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc (right):

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc:103: }
line 88-103: this doesn't need to be done here. I think it would be cleaner to
move NumberOfPlanesForGpuMemoryBufferFormat just before
"mapped_buffers[num_planes]" below and the code in this for-loop here into the
"i < num_planes" for loop below. that way there's no need for these vectors..

https://codereview.chromium.org/1062853002/diff/60001/gpu/command_buffer/test...
File gpu/command_buffer/tests/gl_manager.cc (right):

https://codereview.chromium.org/1062853002/diff/60001/gpu/command_buffer/test...
gpu/command_buffer/tests/gl_manager.cc:135: if (num_planes > 1) {
nit: this if statement is not necessary, the for loop condition expression is
enough.

[emircan, 2015-04-07 20:07:11]

Patchset #3 (id:100001) has been deleted

[emircan, 2015-04-07 20:08:12]

https://codereview.chromium.org/1062853002/diff/60001/cc/test/test_gpu_memory...
File cc/test/test_gpu_memory_buffer_manager.cc (right):

https://codereview.chromium.org/1062853002/diff/60001/cc/test/test_gpu_memory...
cc/test/test_gpu_memory_buffer_manager.cc:8: #include
"base/memory/scoped_vector.h"
On 2015/04/07 19:03:24, reveman wrote:
> nit: you don't need this anymore

Done.

https://codereview.chromium.org/1062853002/diff/60001/cc/test/test_gpu_memory...
cc/test/test_gpu_memory_buffer_manager.cc:109: if (num_planes > 1) {
On 2015/04/07 19:03:24, reveman wrote:
> nit: this if statement is not necessary, the for loop condition expression is
> enough.

For sure. Sorry for missing that, left from my earlier implementation.

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
File content/common/gpu/client/gpu_memory_buffer_impl.cc (right):

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
content/common/gpu/client/gpu_memory_buffer_impl.cc:173: stride_in_bytes *
(size.height() / SubsamplingFactor(format, i));
On 2015/04/07 19:03:25, reveman wrote:
> This multiplication can overflow. You need another CheckedNumeric here to
> protect against it.

Done.

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
File content/common/gpu/client/gpu_memory_buffer_impl.h (right):

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
content/common/gpu/client/gpu_memory_buffer_impl.h:54: static bool
TotalBufferSizeInBytes(const gfx::Size& size,
On 2015/04/07 19:03:25, reveman wrote:
> nit: not sure you need the "Total" prefix, BufferSizeInBytes seems sufficient
> but feel free to keep it if you think it's useful

Done.

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
content/common/gpu/client/gpu_memory_buffer_impl.h:56: size_t*
total_size_in_bytes);
On 2015/04/07 19:03:25, reveman wrote:
> remove "total_" prefix here too if you decide to remove it above

Done.

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
File content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc (right):

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc:142: if
(size.width() % factor != 0 || size.height() % factor != 0)
On 2015/04/07 19:03:25, reveman wrote:
> nit: style guide prefers "size.width() % factor || size.height() % factor"

Done.

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc:159: if
(num_planes > 1) {
On 2015/04/07 19:03:25, reveman wrote:
> nit: this if statement is not necessary, the for loop condition expression is
> enough.

Done.

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc:160: size_t
stride_in_bytes = 0;
On 2015/04/07 19:03:25, reveman wrote:
> nit: you can move this into the for-loop scope

Done.

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc:162: if
(!StrideInBytes(size_.width(), format_, i, &stride_in_bytes))
On 2015/04/07 19:03:25, reveman wrote:
> nit: it's better to DCHECK here if this fails just like ::GetStride.

Done.

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc:179: size_t
stride_in_bytes = 0;
On 2015/04/07 19:03:25, reveman wrote:
> nit: you can move this into the for-loop scope

Done.

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
File content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc (right):

https://codereview.chromium.org/1062853002/diff/60001/content/common/gpu/clie...
content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc:103: }
On 2015/04/07 19:03:25, reveman wrote:
> line 88-103: this doesn't need to be done here. I think it would be cleaner to
> move NumberOfPlanesForGpuMemoryBufferFormat just before
> "mapped_buffers[num_planes]" below and the code in this for-loop here into the
> "i < num_planes" for loop below. that way there's no need for these vectors..

Done.

[reveman, 2015-04-07 20:33:45]

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
File content/common/gpu/client/gpu_memory_buffer_impl.cc (right):

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl.cc:81:
gfx::GpuMemoryBuffer::Format format) {
nit: remove gfx::GpuMemoryBuffer:: prefix if possible to be consistent with
::StrideInBytes

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl.cc:83: case
gfx::GpuMemoryBuffer::Format::ATC:
nit: remove gfx::GpuMemoryBuffer::Format:: prefix if possible

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl.cc:140:
gfx::GpuMemoryBuffer::Format format,
nit: remove gfx::GpuMemoryBuffer:: prefix if possible

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl.cc:143: case
gfx::GpuMemoryBuffer::ATC:
nit: remove gfx::GpuMemoryBuffer::Format:: prefix if possible

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl.cc:165:
gfx::GpuMemoryBuffer::Format format,
nit: remove gfx::GpuMemoryBuffer:: prefix if possible

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl.cc:166: size_t*
total_size_in_bytes) {
nit: s/total_size_in_bytes/size_in_bytes/

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl.cc:167:
base::CheckedNumeric<size_t> size_in_bytes = 0u;
nit: s/size_in_bytes/checked_size_in_bytes/

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl.cc:172:
base::CheckedNumeric<size_t> plane_size =
nit: s/plane_size/checked_plane_size_in_bytes/

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl.cc:173: stride_in_bytes *
(size.height() / SubsamplingFactor(format, i));
This can still overflow. For CheckedNumeric to work you have to do something
like this:

base::CheckedNumeric<size_t> checked_plane_size_in_bytes = stride_in_bytes;
checked_plane_size_in_bytes *= size.height() / SubsamplingFactor(format, i);
if (!checked_plane_size_in_bytes.IsValid())
  return false;

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
File content/common/gpu/client/gpu_memory_buffer_impl.h (right):

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl.h:54: static bool
BufferSizeInBytes(const gfx::Size& size,
nit: can you move this function to GpuMemoryBufferImplSharedMemory and adjust
the comment as other implementations are not forced to use this. they can use a
different total buffer size or the concept of a total buffer size might not even
apply to them..

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
File content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc (right):

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc:121:
memset(data.get(), i, width_in_bytes);
nit: s/i/0x2a + i/ to avoid i=0 which is not very good for testing

[emircan, 2015-04-07 21:28:46]

Please take a look.

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
File content/common/gpu/client/gpu_memory_buffer_impl.cc (right):

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl.cc:81:
gfx::GpuMemoryBuffer::Format format) {
On 2015/04/07 20:33:44, reveman wrote:
> nit: remove gfx::GpuMemoryBuffer:: prefix if possible to be consistent with
> ::StrideInBytes

Done.

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl.cc:83: case
gfx::GpuMemoryBuffer::Format::ATC:
On 2015/04/07 20:33:44, reveman wrote:
> nit: remove gfx::GpuMemoryBuffer::Format:: prefix if possible

Done.

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl.cc:140:
gfx::GpuMemoryBuffer::Format format,
On 2015/04/07 20:33:44, reveman wrote:
> nit: remove gfx::GpuMemoryBuffer:: prefix if possible

Done.

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl.cc:143: case
gfx::GpuMemoryBuffer::ATC:
On 2015/04/07 20:33:44, reveman wrote:
> nit: remove gfx::GpuMemoryBuffer::Format:: prefix if possible

Done.

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl.cc:165:
gfx::GpuMemoryBuffer::Format format,
On 2015/04/07 20:33:44, reveman wrote:
> nit: remove gfx::GpuMemoryBuffer:: prefix if possible

Done.

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl.cc:166: size_t*
total_size_in_bytes) {
On 2015/04/07 20:33:44, reveman wrote:
> nit: s/total_size_in_bytes/size_in_bytes/

Done.

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl.cc:167:
base::CheckedNumeric<size_t> size_in_bytes = 0u;
On 2015/04/07 20:33:44, reveman wrote:
> nit: s/size_in_bytes/checked_size_in_bytes/

Done.

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl.cc:172:
base::CheckedNumeric<size_t> plane_size =
On 2015/04/07 20:33:44, reveman wrote:
> nit: s/plane_size/checked_plane_size_in_bytes/

Done.

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl.cc:173: stride_in_bytes *
(size.height() / SubsamplingFactor(format, i));
On 2015/04/07 20:33:44, reveman wrote:
> This can still overflow. For CheckedNumeric to work you have to do something
> like this:
> 
> base::CheckedNumeric<size_t> checked_plane_size_in_bytes = stride_in_bytes;
> checked_plane_size_in_bytes *= size.height() / SubsamplingFactor(format, i);
> if (!checked_plane_size_in_bytes.IsValid())
>   return false;

Done.

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
File content/common/gpu/client/gpu_memory_buffer_impl.h (right):

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl.h:54: static bool
BufferSizeInBytes(const gfx::Size& size,
On 2015/04/07 20:33:44, reveman wrote:
> nit: can you move this function to GpuMemoryBufferImplSharedMemory and adjust
> the comment as other implementations are not forced to use this. they can use
a
> different total buffer size or the concept of a total buffer size might not
even
> apply to them..

I had it there originally, but then moved it here as
GpuMemoryBufferFactorySharedMemory and FactoryOzone can also use it. But, it
also makes sense to declare new one in ozone using its own formats. 

I added it to GpuMemoryBufferImplSharedMemory and changed include in
GpuMemoryBufferFactorySharedMemory.

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
File content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc (right):

https://codereview.chromium.org/1062853002/diff/120001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc:121:
memset(data.get(), i, width_in_bytes);
On 2015/04/07 20:33:45, reveman wrote:
> nit: s/i/0x2a + i/ to avoid i=0 which is not very good for testing

Done.

[reveman, 2015-04-07 21:43:56]

lgtm with nit

https://codereview.chromium.org/1062853002/diff/140001/content/common/gpu/cli...
File content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h (right):

https://codereview.chromium.org/1062853002/diff/140001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h:27: //
Calculates the number of bytes that an implementation must use to store
nit: s/that an implementation must use/used/

[reveman, 2015-04-07 21:44:38]

reveman@chromium.org changed reviewers:
+ alexst@google.com

[reveman, 2015-04-07 21:44:39]

+alexst for ui/ozone

[emircan, 2015-04-07 21:47:47]

https://codereview.chromium.org/1062853002/diff/140001/content/common/gpu/cli...
File content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h (right):

https://codereview.chromium.org/1062853002/diff/140001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h:27: //
Calculates the number of bytes that an implementation must use to store
On 2015/04/07 21:43:56, reveman wrote:
> nit: s/that an implementation must use/used/

Done.

[alexst (slow to review), 2015-04-08 00:31:13]

alexst@chromium.org changed reviewers:
+ alexst@chromium.org

[alexst (slow to review), 2015-04-08 00:31:14]

lgtm

[emircan, 2015-04-08 00:49:04]

emircan@chromium.org changed reviewers:
+ sievers@chromium.org

[emircan, 2015-04-08 00:49:05]

Thanks. I still need OWNERS review:

sievers for content/common/gpu/client/* and gpu/command_buffer/*

[reveman, 2015-04-08 02:15:23]

reveman@chromium.org changed reviewers:
+ piman@chromium.org

[reveman, 2015-04-08 02:15:24]

+piman for gpu/command_buffer/service/image_factory.cc and
gpu/command_buffer/tests/gl_manager.cc

[reveman, 2015-04-08 02:19:12]

On 2015/04/08 at 02:15:24, reveman wrote:
> +piman for gpu/command_buffer/service/image_factory.cc and
gpu/command_buffer/tests/gl_manager.cc

sorry, I missed that sievers@ had already been added as a reviewer

[piman, 2015-04-08 04:58:05]

lgtm

https://codereview.chromium.org/1062853002/diff/180001/content/common/gpu/cli...
File content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc (right):

https://codereview.chromium.org/1062853002/diff/180001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc:78: for
(size_t i = 0; i < NumberOfPlanesForGpuMemoryBufferFormat(format); ++i) {
nit: hoist the the number of planes out of the loop, to avoid the switch on each
iteration.

https://codereview.chromium.org/1062853002/diff/180001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc:178: for
(size_t i = 0; i < NumberOfPlanesForGpuMemoryBufferFormat(format_) - 1;
nit: same here.

https://codereview.chromium.org/1062853002/diff/180001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc:198: for
(size_t i = 0; i < NumberOfPlanesForGpuMemoryBufferFormat(format_); ++i) {
nit: same here.

[emircan, 2015-04-08 05:04:22]

The CQ bit was checked by emircan@chromium.org

[emircan, 2015-04-08 05:04:23]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/1062853002/#ps180001
(title: " ")

[commit-bot: I haz the power, 2015-04-08 05:04:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062853002/180001

[commit-bot: I haz the power, 2015-04-08 06:25:26]

Committed patchset #6 (id:180001)

[commit-bot: I haz the power, 2015-04-08 06:26:18]

Patchset 6 (id:??) landed as
https://crrev.com/607ed17ba5d0d1c67901ecc7160db660f08bd831
Cr-Commit-Position: refs/heads/master@{#324190}