Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 1062253002: Revert of Reland Track memory consumption of SP on top 7 sites. (Closed)

Created:
5 years, 8 months ago by shatch
Modified:
5 years, 8 months ago
Reviewers:
sullivan, pdr., prasadv, Pan
CC:
chromium-reviews, auto-bisect-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland Track memory consumption of SP on top 7 sites. (patchset #1 id:1 of https://codereview.chromium.org/1052843002/) Reason for revert: I think the original CL meant to make changes to memory.py, not run-perf-test.cfg. We shouldn't be submitting changes to run-perf-test.cfg, this file is used by the perf-try bots to pass try job parameters. Original issue's description: > Track memory consumption of SP on top 7 sites. > > Tests: > android: https://codereview.chromium.org/1023783006/ > linux & mac: https://codereview.chromium.org/1013723006/ > win: https://codereview.chromium.org/1038773002/ > > All above pass the "Running With Patch" step. > > BUG=None > > Committed: https://crrev.com/82b8e167143a5f0d4dd4515c6d0e14a64f654083 > Cr-Commit-Position: refs/heads/master@{#323680} TBR=pdr@chromium.org,sullivan@chromium.org,prasadv@chromium.org,pan.deng@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/e2ab15b7f35de5bea9f0528e88c0f4449f1c4b69 Cr-Commit-Position: refs/heads/master@{#324088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -6 lines) Patch
M tools/run-perf-test.cfg View 1 chunk +76 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
shatch
Created Revert of Reland Track memory consumption of SP on top 7 sites.
5 years, 8 months ago (2015-04-07 19:13:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062253002/1
5 years, 8 months ago (2015-04-07 19:14:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 19:15:18 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e2ab15b7f35de5bea9f0528e88c0f4449f1c4b69 Cr-Commit-Position: refs/heads/master@{#324088}
5 years, 8 months ago (2015-04-07 19:17:13 UTC) #4
pdr.
5 years, 8 months ago (2015-04-07 22:09:18 UTC) #5
Message was sent while issue was closed.
On 2015/04/07 at 19:17:13, commit-bot wrote:
> Patchset 1 (id:??) landed as
https://crrev.com/e2ab15b7f35de5bea9f0528e88c0f4449f1c4b69
> Cr-Commit-Position: refs/heads/master@{#324088}

Thanks for rolling this out. I'm relanding this correctly in
https://codereview.chromium.org/1066223002.

Powered by Google App Engine
This is Rietveld 408576698