Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1066223002: Reland: Track memory consumption of SP on top 7 sites (Closed)

Created:
5 years, 8 months ago by pdr.
Modified:
5 years, 8 months ago
Reviewers:
sullivan, chrishtr, dtu, Sami
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Track memory consumption of SP on top 7 sites This is a reland of the memory perf test. R=chrishtr BUG=474768 Committed: https://crrev.com/378f8be1fc36b0878810f2cfeb9da8436cf95313 Cr-Commit-Position: refs/heads/master@{#324307}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Two blank lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M tools/perf/benchmarks/memory.py View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
chrishtr
lgtm
5 years, 8 months ago (2015-04-07 22:07:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066223002/1
5 years, 8 months ago (2015-04-07 22:08:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/54661)
5 years, 8 months ago (2015-04-07 22:45:35 UTC) #7
pdr.
+cc skyostil, dtu This change has been through the perf bots and got an LGTM ...
5 years, 8 months ago (2015-04-08 01:53:50 UTC) #9
Sami
lgtm. https://codereview.chromium.org/1066223002/diff/1/tools/perf/benchmarks/memory.py File tools/perf/benchmarks/memory.py (right): https://codereview.chromium.org/1066223002/diff/1/tools/perf/benchmarks/memory.py#newcode30 tools/perf/benchmarks/memory.py:30: class MemoryTop7StressWithSlimmingPaint(benchmark.Benchmark): nit: two blank lines between toplevel ...
5 years, 8 months ago (2015-04-08 14:47:50 UTC) #10
dtu
lgtm
5 years, 8 months ago (2015-04-08 17:59:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066223002/20001
5 years, 8 months ago (2015-04-08 20:47:03 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-08 23:34:41 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 23:35:26 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/378f8be1fc36b0878810f2cfeb9da8436cf95313
Cr-Commit-Position: refs/heads/master@{#324307}

Powered by Google App Engine
This is Rietveld 408576698