Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1052843002: Reland Track memory consumption of SP on top 7 sites. (Closed)

Created:
5 years, 8 months ago by Pan
Modified:
5 years, 8 months ago
Reviewers:
sullivan, pdr., prasadv
CC:
chromium-reviews, auto-bisect-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Track memory consumption of SP on top 7 sites. Tests: android: https://codereview.chromium.org/1023783006/ linux & mac: https://codereview.chromium.org/1013723006/ win: https://codereview.chromium.org/1038773002/ All above pass the "Running With Patch" step. BUG=None Committed: https://crrev.com/82b8e167143a5f0d4dd4515c6d0e14a64f654083 Cr-Commit-Position: refs/heads/master@{#323680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -76 lines) Patch
M tools/run-perf-test.cfg View 1 chunk +6 lines, -76 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
Pan
can we reland it now? thanks, Pan
5 years, 8 months ago (2015-04-03 00:48:37 UTC) #2
pdr.
On 2015/04/03 at 00:48:37, pan.deng wrote: > can we reland it now? thanks, Pan Thanks ...
5 years, 8 months ago (2015-04-03 01:15:50 UTC) #3
sullivan
lgtm
5 years, 8 months ago (2015-04-03 01:27:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052843002/1
5 years, 8 months ago (2015-04-03 04:43:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-03 07:57:30 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/82b8e167143a5f0d4dd4515c6d0e14a64f654083 Cr-Commit-Position: refs/heads/master@{#323680}
5 years, 8 months ago (2015-04-03 20:34:57 UTC) #8
shatch
On 2015/04/03 20:34:57, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 8 months ago (2015-04-07 18:32:11 UTC) #9
qyearsley
On 2015/04/07 18:32:11, shatch wrote: > On 2015/04/03 20:34:57, I haz the power (commit-bot) wrote: ...
5 years, 8 months ago (2015-04-07 18:47:43 UTC) #11
shatch
On 2015/04/07 18:47:43, qyearsley wrote: > On 2015/04/07 18:32:11, shatch wrote: > > On 2015/04/03 ...
5 years, 8 months ago (2015-04-07 19:11:45 UTC) #12
shatch
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1062253002/ by simonhatch@chromium.org. ...
5 years, 8 months ago (2015-04-07 19:13:20 UTC) #13
pdr.
On 2015/04/07 at 19:13:20, simonhatch wrote: > A revert of this CL (patchset #1 id:1) ...
5 years, 8 months ago (2015-04-07 22:09:51 UTC) #14
Pan
5 years, 8 months ago (2015-04-08 00:37:20 UTC) #15
Message was sent while issue was closed.
> > The reason for reverting is: I think the original CL meant to make changes
to
> memory.py, not run-perf-test.cfg. We shouldn't be submitting changes to
> run-perf-test.cfg, this file is used by the perf-try bots to pass try job
> parameters..
> 
> I'm relanding this in https://codereview.chromium.org/1066223002.

Oh, my mistake, thanks, Pan.

Powered by Google App Engine
This is Rietveld 408576698