cc: Add ResourceId validation checks at the time of AppendQuads.

cc: Add ResourceId validation checks at the time of AppendQuads.

This will help us track down how an invalid resource is ending up in
the frame hopefully.

R=enne, piman@chromium.org
BUG=455931
Committed: https://crrev.com/26bcd452dc068c3bee6f2b5b31b10cab2076137b
Cr-Commit-Position: refs/heads/master@{#324103}

[danakj, 2015-04-06 23:42:39]

What do you think?

[piman, 2015-04-07 00:13:40]

lgtm

https://codereview.chromium.org/1062043003/diff/1/cc/resources/resource_provi...
File cc/resources/resource_provider.cc (right):

https://codereview.chromium.org/1062043003/diff/1/cc/resources/resource_provi...
cc/resources/resource_provider.cc:2141: CHECK(it != resources_.end());
nit: all that is essentially (void)GetResource(id);

[danakj, 2015-04-07 00:15:00]

https://codereview.chromium.org/1062043003/diff/1/cc/resources/resource_provi...
File cc/resources/resource_provider.cc (right):

https://codereview.chromium.org/1062043003/diff/1/cc/resources/resource_provi...
cc/resources/resource_provider.cc:2141: CHECK(it != resources_.end());
On 2015/04/07 00:13:39, piman (Very slow to review) wrote:
> nit: all that is essentially (void)GetResource(id);

Ya I copied it from there. Heh. My random thought was that I would go back and
remove the CHECK(id) in GetResource, but maybe we'd wanna keep this function
around behind DCHECK_IS_ON() and it'd be nice to keep here. I will add a TODO on
the CHECK in GetResource.

[piman, 2015-04-07 00:17:13]

On Mon, Apr 6, 2015 at 5:15 PM, <danakj@chromium.org> wrote:

>
> https://codereview.chromium.org/1062043003/diff/1/cc/
> resources/resource_provider.cc
> File cc/resources/resource_provider.cc (right):
>
> https://codereview.chromium.org/1062043003/diff/1/cc/
> resources/resource_provider.cc#newcode2141
> cc/resources/resource_provider.cc:2141: CHECK(it != resources_.end());
> On 2015/04/07 00:13:39, piman (Very slow to review) wrote:
>
>> nit: all that is essentially (void)GetResource(id);
>>
>
> Ya I copied it from there. Heh. My random thought was that I would go
> back and remove the CHECK(id) in GetResource, but maybe we'd wanna keep
> this function around behind DCHECK_IS_ON() and it'd be nice to keep
> here. I will add a TODO on the CHECK in GetResource.
>

Ok.


>
> https://codereview.chromium.org/1062043003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2015-04-07 02:15:38]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-04-07 02:15:38]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1062043003/#ps20001
(title: "resource-validate: todo")

[commit-bot: I haz the power, 2015-04-07 02:15:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062043003/20001

[commit-bot: I haz the power, 2015-04-07 03:52:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-07 03:52:05]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2015-04-07 18:41:10]

Had to fix a number of unit tests that were inventing their own resource ids to
call CreateResource().

[danakj, 2015-04-07 18:44:16]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-04-07 18:44:17]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1062043003/#ps40001
(title: "resource-validate: fixtests")

[commit-bot: I haz the power, 2015-04-07 18:44:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062043003/40001

[commit-bot: I haz the power, 2015-04-07 20:14:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-07 20:15:53]

Patchset 3 (id:??) landed as
https://crrev.com/26bcd452dc068c3bee6f2b5b31b10cab2076137b
Cr-Commit-Position: refs/heads/master@{#324103}

[kouhei (in TOK), 2015-04-08 17:49:41]

kouhei@chromium.org changed reviewers:
+ kouhei@chromium.org

[kouhei (in TOK), 2015-04-08 17:49:42]

Suspecting this CL as cause of http://crbug.com/475099 . Would you take a look?