cc/layers/picture_layer_impl.cc - Issue 1062043003: cc: Add ResourceId validation checks at the time of AppendQuads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/picture_layer_impl.cc

Issue 1062043003: cc: Add ResourceId validation checks at the time of AppendQuads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: resource-validate: fixtests Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/picture_layer_impl.cc

diff --git a/cc/layers/picture_layer_impl.cc b/cc/layers/picture_layer_impl.cc

index c8d7efae4eecf2ff8b2bb9e2b65a6cb0f74c1e5c..e9188ec678fbefb736b8a5db9d70934fc354392d 100644

--- a/cc/layers/picture_layer_impl.cc

+++ b/cc/layers/picture_layer_impl.cc

@@ -305,6 +305,9 @@ void PictureLayerImpl::AppendQuads(RenderPass* render_pass,

append_quads_data->num_incomplete_tiles++;

}

+ // TODO(danakj): crbug.com/455931

+ layer_tree_impl()->resource_provider()->ValidateResource(

+ draw_info.resource_id());

TileDrawQuad* quad =

render_pass->CreateAndAppendDrawQuad<TileDrawQuad>();

quad->SetNew(shared_quad_state, geometry_rect, opaque_rect,

« no previous file with comments | « cc/layers/painted_scrollbar_layer_impl.cc ('k') | cc/layers/texture_layer_impl.cc » ('j') | no next file with comments »