cc/layers/tiled_layer_impl.cc - Issue 1062043003: cc: Add ResourceId validation checks at the time of AppendQuads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/tiled_layer_impl.cc

Issue 1062043003: cc: Add ResourceId validation checks at the time of AppendQuads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: resource-validate: fixtests Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/tiled_layer_impl.cc

diff --git a/cc/layers/tiled_layer_impl.cc b/cc/layers/tiled_layer_impl.cc

index 04aad2da84b5bfada16462b9486b0445fb1f52d9..f2b2b00190cda9c9bdd46a096897c8ee9de03910 100644

--- a/cc/layers/tiled_layer_impl.cc

+++ b/cc/layers/tiled_layer_impl.cc

@@ -16,6 +16,7 @@

#include "cc/quads/solid_color_draw_quad.h"

#include "cc/quads/tile_draw_quad.h"

#include "cc/resources/layer_tiling_data.h"

+#include "cc/trees/layer_tree_impl.h"

#include "cc/trees/occlusion.h"

#include "third_party/skia/include/core/SkColor.h"

#include "ui/gfx/geometry/quad_f.h"

@@ -259,6 +260,9 @@ void TiledLayerImpl::AppendQuads(RenderPass* render_pass,

float tile_height = static_cast<float>(tiler_->tile_size().height());

gfx::Size texture_size(tile_width, tile_height);

+ // TODO(danakj): crbug.com/455931

+ layer_tree_impl()->resource_provider()->ValidateResource(

+ tile->resource_id());

TileDrawQuad* quad = render_pass->CreateAndAppendDrawQuad<TileDrawQuad>();

quad->SetNew(shared_quad_state,

tile_rect,

« no previous file with comments | « cc/layers/texture_layer_impl.cc ('k') | cc/layers/tiled_layer_impl_unittest.cc » ('j') | no next file with comments »