Source/modules/accessibility/AXMenuList.h - Issue 1059503002: Re-land: Don't keep recreating AXMenuListPopup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXMenuList.h

Issue 1059503002: Re-land: Don't keep recreating AXMenuListPopup (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@suppress_extra_events

Patch Set: Clean up code Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/accessibility/menu-list-popup-reuses-objects-expected.txt ('k') | Source/modules/accessibility/AXMenuList.cpp » ('j') | Source/modules/accessibility/AXMenuListOption.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/accessibility/AXMenuList.h

diff --git a/Source/modules/accessibility/AXMenuList.h b/Source/modules/accessibility/AXMenuList.h

index 4101a2f5c3fbc64875bd9ed2823857a9dc1d2e6a..b057fe62a81927bd6d2e424af90d8619132ee4ea 100644

--- a/Source/modules/accessibility/AXMenuList.h

+++ b/Source/modules/accessibility/AXMenuList.h

@@ -40,6 +40,7 @@ public:

virtual bool isCollapsed() const override;

virtual AccessibilityExpanded isExpanded() const override final;

virtual bool press() const override;

+ virtual void updateChildrenIfNecessary() override;

virtual void clearChildren() override;

void didUpdateActiveOption(int optionIndex);