Source/modules/accessibility/AXMenuList.cpp - Issue 1059503002: Re-land: Don't keep recreating AXMenuListPopup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXMenuList.cpp

Issue 1059503002: Re-land: Don't keep recreating AXMenuListPopup (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@suppress_extra_events

Patch Set: Clean up code Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/accessibility/AXMenuList.h ('k') | Source/modules/accessibility/AXMenuListOption.h » ('j') | Source/modules/accessibility/AXMenuListOption.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/accessibility/AXMenuList.cpp

diff --git a/Source/modules/accessibility/AXMenuList.cpp b/Source/modules/accessibility/AXMenuList.cpp

index 6e7b9029e772a95f4086403772897897586fbb47..801aca2760e7579644e06fd8bbb1d6373a25d375 100644

--- a/Source/modules/accessibility/AXMenuList.cpp

+++ b/Source/modules/accessibility/AXMenuList.cpp

@@ -60,6 +60,20 @@ bool AXMenuList::press() const

return true;

}

+void AXMenuList::updateChildrenIfNecessary()

+ if (m_children.isEmpty()) {

+ addChildren();

+ return;

+ }

+ // There's no reason to update our AXMenuListPopup child. If we get a

+ // call to updateChildrenIfNecessary, it's because the options might have

+ // changed, so call it on our popup.

+ ASSERT(m_children.size() == 1);

+ m_children[0]->updateChildrenIfNecessary();

void AXMenuList::clearChildren()

{

if (m_children.isEmpty())