Source/modules/accessibility/AXMenuList.h - Issue 1059503002: Re-land: Don't keep recreating AXMenuListPopup

Side by Side Diff: Source/modules/accessibility/AXMenuList.h

Issue 1059503002: Re-land: Don't keep recreating AXMenuListPopup (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@suppress_extra_events

Patch Set: Clean up code Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/accessibility/menu-list-popup-reuses-objects-expected.txt ('k') | Source/modules/accessibility/AXMenuList.cpp » ('j') | Source/modules/accessibility/AXMenuListOption.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Apple Inc. All Rights Reserved.	2 * Copyright (C) 2010 Apple Inc. All Rights Reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 22 matching lines...) Expand all Loading...
33 class AXObjectCacheImpl;	33 class AXObjectCacheImpl;

34 class LayoutMenuList;	34 class LayoutMenuList;

35	35

36 class AXMenuList final : public AXLayoutObject {	36 class AXMenuList final : public AXLayoutObject {

37 public:	37 public:

38 static PassRefPtr<AXMenuList> create(LayoutMenuList* layoutObject, AXObjectC acheImpl*);	38 static PassRefPtr<AXMenuList> create(LayoutMenuList* layoutObject, AXObjectC acheImpl*);

39	39

40 virtual bool isCollapsed() const override;	40 virtual bool isCollapsed() const override;

41 virtual AccessibilityExpanded isExpanded() const override final;	41 virtual AccessibilityExpanded isExpanded() const override final;

42 virtual bool press() const override;	42 virtual bool press() const override;

	43 virtual void updateChildrenIfNecessary() override;

43 virtual void clearChildren() override;	44 virtual void clearChildren() override;

44	45

45 void didUpdateActiveOption(int optionIndex);	46 void didUpdateActiveOption(int optionIndex);

46 void didShowPopup();	47 void didShowPopup();

47 void didHidePopup();	48 void didHidePopup();

48	49

49 private:	50 private:

50 AXMenuList(LayoutMenuList, AXObjectCacheImpl);	51 AXMenuList(LayoutMenuList, AXObjectCacheImpl);

51	52

52 virtual bool isMenuList() const override { return true; }	53 virtual bool isMenuList() const override { return true; }

53 virtual AccessibilityRole roleValue() const override;	54 virtual AccessibilityRole roleValue() const override;

54 virtual bool canSetFocusAttribute() const override;	55 virtual bool canSetFocusAttribute() const override;

55	56

56 virtual void addChildren() override;	57 virtual void addChildren() override;

57 virtual void childrenChanged() override;	58 virtual void childrenChanged() override;

58 };	59 };

59	60

60 DEFINE_AX_OBJECT_TYPE_CASTS(AXMenuList, isMenuList());	61 DEFINE_AX_OBJECT_TYPE_CASTS(AXMenuList, isMenuList());

61	62

62 } // namespace blink	63 } // namespace blink

63	64

64 #endif // AXMenuList_h	65 #endif // AXMenuList_h

OLD	NEW