Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1059393002: Remove --respect-autocomplete-off-autofill flag. (Closed)

Created:
5 years, 8 months ago by Evan Stade
Modified:
5 years, 8 months ago
Reviewers:
Tom Sepez, brettw
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org, Justin Donnelly
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove --respect-autocomplete-off-autofill flag. BUG=425672 Committed: https://crrev.com/a15be7b0c8ca766276bb5eec23806361b3bdd8d7 Cr-Commit-Position: refs/heads/master@{#323993}

Patch Set 1 #

Patch Set 2 : slight update #

Patch Set 3 : always display warning too #

Patch Set 4 : plus a comment #

Patch Set 5 : fix browser tests #

Patch Set 6 : rebase #

Patch Set 7 : fix last 3 tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -633 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/autofill/autofill_renderer_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -53 lines 0 comments Download
M chrome/renderer/autofill/form_autofill_browsertest.cc View 1 2 3 4 5 6 28 chunks +42 lines, -163 lines 0 comments Download
M chrome/renderer/autofill/password_autofill_agent_browsertest.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/autofill/password_generation_agent_browsertest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/content/common/autofill_messages.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.h View 1 2 3 chunks +0 lines, -9 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 2 3 4 10 chunks +6 lines, -48 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.h View 4 chunks +6 lines, -13 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 1 16 chunks +14 lines, -56 lines 0 comments Download
M components/autofill/content/renderer/form_cache.cc View 1 5 chunks +7 lines, -10 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M components/autofill/content/renderer/password_form_conversion_utils.cc View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/core/browser/autofill_external_delegate.h View 1 2 2 chunks +4 lines, -10 lines 0 comments Download
M components/autofill/core/browser/autofill_external_delegate.cc View 1 2 3 4 4 chunks +5 lines, -40 lines 0 comments Download
M components/autofill/core/browser/autofill_external_delegate_unittest.cc View 1 2 4 chunks +2 lines, -54 lines 0 comments Download
M components/autofill/core/browser/autofill_field.cc View 1 2 3 4 5 1 chunk +1 line, -4 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.h View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 2 3 4 5 2 chunks +6 lines, -15 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 2 3 4 3 chunks +4 lines, -41 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics_unittest.cc View 1 2 33 chunks +35 lines, -70 lines 0 comments Download
M components/autofill/core/browser/form_structure_unittest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M components/autofill/core/browser/test_autofill_external_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/common/autofill_constants.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/common/autofill_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/common/autofill_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Evan Stade
+tsepez for ipc +brettw for the rest jdonnelly's comment on crbug.com/459456 reminded me I needed ...
5 years, 8 months ago (2015-04-03 21:52:12 UTC) #2
Tom Sepez
RS LGTM on messages for deleting a parameter.
5 years, 8 months ago (2015-04-03 21:56:55 UTC) #3
brettw
lgtm
5 years, 8 months ago (2015-04-06 18:16:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059393002/100001
5 years, 8 months ago (2015-04-06 18:20:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/43388)
5 years, 8 months ago (2015-04-06 19:39:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059393002/120001
5 years, 8 months ago (2015-04-07 00:06:20 UTC) #12
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 8 months ago (2015-04-07 00:56:13 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 00:57:05 UTC) #14
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/a15be7b0c8ca766276bb5eec23806361b3bdd8d7
Cr-Commit-Position: refs/heads/master@{#323993}

Powered by Google App Engine
This is Rietveld 408576698