Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils.cc

Issue 1059393002: Remove --respect-autocomplete-off-autofill flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix last 3 tests Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_form_conversion_utils.cc
diff --git a/components/autofill/content/renderer/password_form_conversion_utils.cc b/components/autofill/content/renderer/password_form_conversion_utils.cc
index 7ad5814273126fa24f9014b298a63b3ed370cebd..2ac5497d911e421392253a4446d270a5af754e6f 100644
--- a/components/autofill/content/renderer/password_form_conversion_utils.cc
+++ b/components/autofill/content/renderer/password_form_conversion_utils.cc
@@ -187,9 +187,10 @@ void FindPredictedUsernameElement(
WebVector<WebFormControlElement>* control_elements,
WebInputElement* predicted_username_element) {
FormData form_data;
- if (!WebFormElementToFormData(form, WebFormControlElement(), REQUIRE_NONE,
- EXTRACT_NONE, &form_data, nullptr))
+ if (!WebFormElementToFormData(form, WebFormControlElement(), EXTRACT_NONE,
+ &form_data, nullptr)) {
return;
+ }
// Prediction forms are not user submitted, but |form| can be user submitted.
// We don't care about this flag for finding predictions, so set it to false.
@@ -199,7 +200,7 @@ void FindPredictedUsernameElement(
return;
std::vector<blink::WebFormControlElement> autofillable_elements =
- ExtractAutofillableElementsFromSet(*control_elements, REQUIRE_NONE);
+ ExtractAutofillableElementsFromSet(*control_elements);
DCHECK_EQ(autofillable_elements.size(), form_data.fields.size());
const autofill::FormFieldData& username_field = predictions_iterator->second;
@@ -441,7 +442,6 @@ scoped_ptr<PasswordForm> CreatePasswordForm(
WebFormElementToFormData(web_form,
blink::WebFormControlElement(),
- REQUIRE_NONE,
EXTRACT_NONE,
&password_form->form_data,
NULL /* FormFieldData */);

Powered by Google App Engine
This is Rietveld 408576698