components/autofill/content/renderer/password_autofill_agent.cc - Issue 1059393002: Remove --respect-autocomplete-off-autofill flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 1059393002: Remove --respect-autocomplete-off-autofill flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix last 3 tests Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/content/renderer/password_autofill_agent.cc

diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc

index 96eee5d8a2dbef1fe4f17380c4952205b13078a3..237f23a2055d901e576ffbec07b6c432635b31fc 100644

--- a/components/autofill/content/renderer/password_autofill_agent.cc

+++ b/components/autofill/content/renderer/password_autofill_agent.cc

@@ -1264,8 +1264,7 @@ bool PasswordAutofillAgent::ShowSuggestionPopup(

FormData form;

FormFieldData field;

- FindFormAndFieldForFormControlElement(

- user_input, &form, &field, REQUIRE_NONE);

+ FindFormAndFieldForFormControlElement(user_input, &form, &field);

blink::WebInputElement selected_element = user_input;

if (show_on_password_field && !selected_element.isPasswordField()) {