Revert 239280 "Move more file_util functions to base namespace."

Revert 239280 "Move more file_util functions to base namespace."

dbus_unittests started fialing on Linux Tests (dbg)(2) and Linux Tests (dbg)(2)(32).
This CL is the only in the intersection of CLs in the first failing build on
the two builders, so giving a speculative revert a try (rlarocque already
tried a clobber, it didn't help).

http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/41806
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/builds/8544


> Move more file_util functions to base namespace.
> 
> TBR=sky
> 
> Review URL: https://codereview.chromium.org/109043002

TBR=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239400

[Nico, 2013-12-08 21:31:48]

Committed patchset #1 manually as r239400.

[Nico, 2013-12-08 21:36:43]

Oh sorry, the dbus_unittests stdout log actually contains

/mnt/data/b/build/slave/Linux_Tests__dbg__2__32_/build/src/out/Debug/dbus_unittests:
symbol lookup error:
/mnt/data/b/build/slave/Linux_Tests__dbg__2__32_/build/src/out/Debug/dbus_unittests:
undefined symbol: _ZN9file_util8OpenFileERKN4base8FilePathEPKc

I didn't see that until after I landed the revert, would've probably been
easier to fix than to revert :-/



On Sun, Dec 8, 2013 at 1:31 PM, <thakis@chromium.org> wrote:

> Committed patchset #1 manually as r239400.
>
> https://codereview.chromium.org/105823009/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2013-12-08 21:38:21]

Also, nothing builds with this reverted. Reverting the revert.


On Sun, Dec 8, 2013 at 1:36 PM, Nico Weber <thakis@chromium.org> wrote:

> Oh sorry, the dbus_unittests stdout log actually contains
>
>
/mnt/data/b/build/slave/Linux_Tests__dbg__2__32_/build/src/out/Debug/dbus_unittests:
> symbol lookup error:
>
/mnt/data/b/build/slave/Linux_Tests__dbg__2__32_/build/src/out/Debug/dbus_unittests:
> undefined symbol: _ZN9file_util8OpenFileERKN4base8FilePathEPKc
>
> I didn't see that until after I landed the revert, would've probably been
> easier to fix than to revert :-/
>
>
>
> On Sun, Dec 8, 2013 at 1:31 PM, <thakis@chromium.org> wrote:
>
>> Committed patchset #1 manually as r239400.
>>
>> https://codereview.chromium.org/105823009/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2013-12-08 21:58:08]

Compile output from when your change landed:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%...

ninja -C /b/build/slave/Linux_Builder__dbg__32_/build/src/out/Debug
base_unittests browser_tests cacheinvalidation_unittests cc_unittests
chrome chromedriver2_unittests components_unittests content_browsertests
content_unittests crypto_unittests device_unittests google_apis_unittests
gpu_unittests interactive_ui_tests ipc_tests jingle_unittests
media_unittests net_unittests ppapi_unittests printing_unittests
remoting_unittests sandbox_linux_unittests sql_unittests sync_unit_tests
ui_unittests unit_tests url_unittests webkit_compositor_bindings_unittests
-j50

The builder doesn't build dbus_unittests :-/ Good thing it does a
components build, else we'd never have noticed that it's been testing a
stale binary.

Oh, it looks like it got removed from the builders list just 2 days ago
here: https://codereview.chromium.org/107313002 but the testers are still
running it since we have that weird test renaming thing in
https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/ma...
the test is actually added as 'dbus' so agable didn't see it and
didn't
remove it. I guess I'll send a CL for that.


On Sun, Dec 8, 2013 at 1:38 PM, Nico Weber <thakis@chromium.org> wrote:

> Also, nothing builds with this reverted. Reverting the revert.
>
>
> On Sun, Dec 8, 2013 at 1:36 PM, Nico Weber <thakis@chromium.org> wrote:
>
>> Oh sorry, the dbus_unittests stdout log actually contains
>>
>>
/mnt/data/b/build/slave/Linux_Tests__dbg__2__32_/build/src/out/Debug/dbus_unittests:
>> symbol lookup error:
>>
/mnt/data/b/build/slave/Linux_Tests__dbg__2__32_/build/src/out/Debug/dbus_unittests:
>> undefined symbol: _ZN9file_util8OpenFileERKN4base8FilePathEPKc
>>
>> I didn't see that until after I landed the revert, would've probably been
>> easier to fix than to revert :-/
>>
>>
>>
>> On Sun, Dec 8, 2013 at 1:31 PM, <thakis@chromium.org> wrote:
>>
>>> Committed patchset #1 manually as r239400.
>>>
>>> https://codereview.chromium.org/105823009/
>>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2013-12-08 22:00:27]

https://codereview.chromium.org/109813002/


On Sun, Dec 8, 2013 at 1:58 PM, Nico Weber <thakis@chromium.org> wrote:

> Compile output from when your change landed:
>
http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%...
>
> ninja -C /b/build/slave/Linux_Builder__dbg__32_/build/src/out/Debug
> base_unittests browser_tests cacheinvalidation_unittests cc_unittests
> chrome chromedriver2_unittests components_unittests content_browsertests
> content_unittests crypto_unittests device_unittests google_apis_unittests
> gpu_unittests interactive_ui_tests ipc_tests jingle_unittests
> media_unittests net_unittests ppapi_unittests printing_unittests
> remoting_unittests sandbox_linux_unittests sql_unittests sync_unit_tests
> ui_unittests unit_tests url_unittests webkit_compositor_bindings_unittests
> -j50
>
> The builder doesn't build dbus_unittests :-/ Good thing it does a
> components build, else we'd never have noticed that it's been testing a
> stale binary.
>
> Oh, it looks like it got removed from the builders list just 2 days ago
> here: https://codereview.chromium.org/107313002 but the testers are still
> running it since we have that weird test renaming thing in
>
https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/ma...
the test is actually added as 'dbus' so agable didn't see it and didn't
> remove it. I guess I'll send a CL for that.
>
>
> On Sun, Dec 8, 2013 at 1:38 PM, Nico Weber <thakis@chromium.org> wrote:
>
>> Also, nothing builds with this reverted. Reverting the revert.
>>
>>
>> On Sun, Dec 8, 2013 at 1:36 PM, Nico Weber <thakis@chromium.org> wrote:
>>
>>> Oh sorry, the dbus_unittests stdout log actually contains
>>>
>>>
/mnt/data/b/build/slave/Linux_Tests__dbg__2__32_/build/src/out/Debug/dbus_unittests:
>>> symbol lookup error:
>>>
/mnt/data/b/build/slave/Linux_Tests__dbg__2__32_/build/src/out/Debug/dbus_unittests:
>>> undefined symbol: _ZN9file_util8OpenFileERKN4base8FilePathEPKc
>>>
>>> I didn't see that until after I landed the revert, would've probably
>>> been easier to fix than to revert :-/
>>>
>>>
>>>
>>> On Sun, Dec 8, 2013 at 1:31 PM, <thakis@chromium.org> wrote:
>>>
>>>> Committed patchset #1 manually as r239400.
>>>>
>>>> https://codereview.chromium.org/105823009/
>>>>
>>>
>>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.