Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1058083003: Revert recent changes to the Fullscreen UA style sheet (Closed)

Created:
5 years, 8 months ago by philipj_slow
Modified:
5 years, 8 months ago
Reviewers:
falken
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Revert recent changes to the Fullscreen UA style sheet This reverts four recent CLs: * Match the Fullscreen spec's CSS as far as currently practical: https://codereview.chromium.org/974783002 * Move translate:none to the standard Fullscreen UA style sheet: https://codereview.chromium.org/1014853003 * Remove border and padding from iframes in fullscreen: https://codereview.chromium.org/1032113002 * Move iframe border/padding to the standard Fullscreen UA style sheet: https://codereview.chromium.org/1032253002 There are multiple unresolved regressions due to the changes: * Weird distorted page seen after exiting from full screen mode in Sleepy Jack app: https://code.google.com/p/chromium/issues/detail?id=468278 * 'Print Preview' fails on 'Awesome-3d-clock' app: https://code.google.com/p/chromium/issues/detail?id=470057 * Unable to toggle out of fullscreen mode after clicking on 'fullscreen' icon for "cordy" app: https://code.google.com/p/chromium/issues/detail?id=475829 These are release blockers and will take some time to investigate, so revert for this release. BUG=402378 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -202 lines) Patch
M LayoutTests/fullscreen/enter-exit-full-screen-hover.html View 2 chunks +1 line, -9 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-iframe-zIndex.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fullscreen/full-screen-render-inline-expected.html View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fullscreen/full-screen-zIndex-expected.html View 1 chunk +6 lines, -5 lines 0 comments Download
M LayoutTests/fullscreen/parent-flow-inline-with-block-child-expected.html View 1 chunk +2 lines, -2 lines 0 comments Download
D LayoutTests/fullscreen/rendering/ua-style-override.html View 1 chunk +0 lines, -59 lines 0 comments Download
D LayoutTests/fullscreen/rendering/ua-style-override-iframe.html View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/fullscreen/rendering/ua-style-root.html View 1 chunk +0 lines, -49 lines 0 comments Download
M Source/core/css/fullscreen.css View 2 chunks +38 lines, -42 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
philipj_slow
PTAL. Fullscreen changes are hard :(
5 years, 8 months ago (2015-04-15 11:17:34 UTC) #2
falken
unfortunate lgtm :(
5 years, 8 months ago (2015-04-15 14:47:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058083003/1
5 years, 8 months ago (2015-04-15 14:50:54 UTC) #5
falken
BTW thanks for the great work on this and for the great detailed CL description, ...
5 years, 8 months ago (2015-04-15 15:11:14 UTC) #6
philipj_slow
On 2015/04/15 15:11:14, falken wrote: > BTW thanks for the great work on this and ...
5 years, 8 months ago (2015-04-15 15:25:05 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 16:11:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193799

Powered by Google App Engine
This is Rietveld 408576698