Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1032253002: Move iframe border/padding to the standard Fullscreen UA style sheet (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Move iframe border/padding to the standard Fullscreen UA style sheet This spec bug was resolved very quickly: (Thanks, Anne!) https://www.w3.org/Bugs/Public/show_bug.cgi?id=28332 The ua-style-iframe-border.html test is no longer needed, as it was written specifically to handle the fact that the border rule was not !important, which it now is. BUG=402378 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192610

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -36 lines) Patch
D LayoutTests/fullscreen/rendering/ua-style-iframe-border.html View 1 chunk +0 lines, -25 lines 0 comments Download
M Source/core/css/fullscreen.css View 1 chunk +2 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
5 years, 9 months ago (2015-03-26 03:50:11 UTC) #2
Julien - ping for review
lgtm
5 years, 9 months ago (2015-03-26 15:43:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032253002/1
5 years, 9 months ago (2015-03-26 15:43:37 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 15:47:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192610

Powered by Google App Engine
This is Rietveld 408576698