Issue 1032113002: Remove border and padding from iframes in fullscreen

Issue 1032113002: Remove border and padding from iframes in fullscreen (Closed)

Created:
5 years, 9 months ago by philipj_slow

Modified:
5 years, 9 months ago

Reviewers:
Julien - ping for review

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/remotes/origin/master

Project:
blink

Visibility:
Public.

Remove border and padding from iframes in fullscreen This restores two rules dropped in the spec sync: https://codereview.chromium.org/974783002 Without the border:none rule, http://html5-demos.appspot.com/static/fullscreen.html gets a 1px white border in fullscreen, which looks particularly odd due to the rounded borders in this demo. Without the padding:0 rule, https://play.google.com/store/movies?hl=en gets a 60px white padding at the top of the fullscreen iframe, which is clearly not the intended design. BUG=402378, 468292, 469133 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192567

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -1 line)			Patch
M	LayoutTests/fullscreen/full-screen-iframe-zIndex-expected.html	View	1 chunk	+0 lines, -1 line	0 comments	Download
A	LayoutTests/fullscreen/rendering/ua-style-override-iframe.html	View	1 chunk	+34 lines, -0 lines	0 comments	Download
M	Source/core/css/fullscreen.css	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032113002/1

5 years, 9 months ago (2015-03-26 01:16:56 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-26 01:20:28 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192567