Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 1057643002: Add PSS.getActiveDataTypes(). (Closed)

Created:
5 years, 8 months ago by Nicolas Zea
Modified:
5 years, 8 months ago
Reviewers:
maxbogue
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2311
Target Ref:
refs/pending/branch-heads/2311
Project:
chromium
Visibility:
Public.

Description

Add PSS.getActiveDataTypes(). Currently PSS.getPreferredDataTypes actually returns PSS::getActiveDataTypes(), which causes some problems. This CL is 1/3. The second will change the appropriate downstream calls to getActiveDataTypes() and the third will fix getPreferredDataTypes(). BUG=466223 TBR=maxbogue@chromium.org Review URL: https://codereview.chromium.org/1017683005 Cr-Commit-Position: refs/heads/master@{#321217} (cherry picked from commit 86e260e3374e107306d8759e78f886a5f5c0de6e) Committed: https://chromium.googlesource.com/chromium/src/+/da2ce9b1ab173b812f31b513c0c69e57cbe41740

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -10 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java View 2 chunks +21 lines, -5 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_android.h View 1 chunk +9 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_android.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Nicolas Zea
5 years, 8 months ago (2015-04-01 20:24:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
da2ce9b1ab173b812f31b513c0c69e57cbe41740 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698