Add PSS.getActiveDataTypes().

Add PSS.getActiveDataTypes().

Currently PSS.getPreferredDataTypes actually returns
PSS::getActiveDataTypes(), which causes some problems. This CL is 1/3.
The second will change the appropriate downstream calls to
getActiveDataTypes() and the third will fix getPreferredDataTypes().

BUG=466223
Committed: https://crrev.com/86e260e3374e107306d8759e78f886a5f5c0de6e
Cr-Commit-Position: refs/heads/master@{#321217}

[maxbogue, 2015-03-17 18:36:42]

maxbogue@chromium.org changed reviewers:
+ nyquist@chromium.org

[maxbogue, 2015-03-17 18:36:43]

PTAL! Should be an easy one.

[nyquist, 2015-03-17 21:25:02]

The CQ bit was checked by nyquist@chromium.org

[nyquist, 2015-03-17 21:25:02]

lgtm

[commit-bot: I haz the power, 2015-03-17 21:26:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1017683005/20001

[commit-bot: I haz the power, 2015-03-17 21:51:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-17 21:51:08]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[maxbogue, 2015-03-17 23:40:34]

maxbogue@chromium.org changed reviewers:
+ zea@google.com

[maxbogue, 2015-03-17 23:40:35]

+zea for owners over profile_sync_service_android

[maxbogue, 2015-03-18 17:56:56]

maxbogue@chromium.org changed reviewers:
+ zea@chromium.org
- zea@google.com

[Nicolas Zea, 2015-03-18 17:57:06]

LGTM

https://codereview.chromium.org/1017683005/diff/1/chrome/browser/sync/profile...
File chrome/browser/sync/profile_sync_service_android.cc (right):

https://codereview.chromium.org/1017683005/diff/1/chrome/browser/sync/profile...
chrome/browser/sync/profile_sync_service_android.cc:351: jobject obj) {
nit: Fix indent

https://codereview.chromium.org/1017683005/diff/1/chrome/browser/sync/profile...
chrome/browser/sync/profile_sync_service_android.cc:353:
types.PutAll(syncer::ControlTypes());
nit: Is this necessary? Nothing outside of sync really needs to know about the
control types, we can probably leave this out.

[maxbogue, 2015-03-18 20:51:07]

https://codereview.chromium.org/1017683005/diff/1/chrome/browser/sync/profile...
File chrome/browser/sync/profile_sync_service_android.cc (right):

https://codereview.chromium.org/1017683005/diff/1/chrome/browser/sync/profile...
chrome/browser/sync/profile_sync_service_android.cc:351: jobject obj) {
On 2015/03/18 17:57:06, Nicolas Zea wrote:
> nit: Fix indent

Done.

https://codereview.chromium.org/1017683005/diff/1/chrome/browser/sync/profile...
chrome/browser/sync/profile_sync_service_android.cc:353:
types.PutAll(syncer::ControlTypes());
On 2015/03/18 17:57:06, Nicolas Zea wrote:
> nit: Is this necessary? Nothing outside of sync really needs to know about the
> control types, we can probably leave this out.

This allows the control types to register for invalidations, so it is necessary.

[maxbogue, 2015-03-18 20:51:10]

The CQ bit was checked by maxbogue@chromium.org

[maxbogue, 2015-03-18 20:51:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
nyquist@chromium.org, zea@chromium.org
Link to the patchset: https://codereview.chromium.org/1017683005/#ps40001
(title: "Fix indentation.")

[commit-bot: I haz the power, 2015-03-18 20:51:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1017683005/40001

[commit-bot: I haz the power, 2015-03-18 21:56:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-18 21:57:05]

Patchset 3 (id:??) landed as
https://crrev.com/86e260e3374e107306d8759e78f886a5f5c0de6e
Cr-Commit-Position: refs/heads/master@{#321217}