Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1681)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java

Issue 1057643002: Add PSS.getActiveDataTypes(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2311
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/profile_sync_service_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java b/chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java
index 75d03dbac9c93164d00013358beec443448388a7..24017411efb3f075548785dff640aab0e0893ff3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java
@@ -328,13 +328,28 @@ public class ProfileSyncService {
}
/**
- * Gets the set of data types that are currently enabled to sync.
+ * Gets the set of data types that are currently syncing.
*
- * @return Set of enabled types.
+ * This is affected by whether sync is on.
+ *
+ * @return Set of active data types.
+ */
+ public Set<ModelType> getActiveDataTypes() {
+ long modelTypeSelection = nativeGetActiveDataTypes(mNativeProfileSyncServiceAndroid);
+ return modelTypeSelectionToSet(modelTypeSelection);
+ }
+
+ /**
+ * Gets the set of data types that are enabled in sync.
+ *
+ * This is unaffected by whether sync is on.
+ *
+ * @return Set of preferred types.
*/
public Set<ModelType> getPreferredDataTypes() {
- long modelTypeSelection =
- nativeGetEnabledDataTypes(mNativeProfileSyncServiceAndroid);
+ // TODO(maxbogue): Correct this line to GetPreferredDataTypes once
+ // downstream uses are fixed.
+ long modelTypeSelection = nativeGetActiveDataTypes(mNativeProfileSyncServiceAndroid);
return modelTypeSelectionToSet(modelTypeSelection);
}
@@ -588,7 +603,8 @@ public class ProfileSyncService {
private native String nativeGetSyncEnterCustomPassphraseBodyText(
long nativeProfileSyncServiceAndroid);
private native boolean nativeIsSyncKeystoreMigrationDone(long nativeProfileSyncServiceAndroid);
- private native long nativeGetEnabledDataTypes(long nativeProfileSyncServiceAndroid);
+ private native long nativeGetActiveDataTypes(long nativeProfileSyncServiceAndroid);
+ private native long nativeGetPreferredDataTypes(long nativeProfileSyncServiceAndroid);
private native void nativeSetPreferredDataTypes(
long nativeProfileSyncServiceAndroid, boolean syncEverything, long modelTypeSelection);
private native void nativeSetSetupInProgress(
« no previous file with comments | « no previous file | chrome/browser/sync/profile_sync_service_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698