Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 105733003: Move LaunchType out of ExtensionPrefs. (Closed)

Created:
7 years ago by Daniel Erat
Modified:
7 years ago
Reviewers:
xiyuan, Yoyo Zhou, benwells
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, sadrul, jar (doing other things), estade+watch_chromium.org, tfarina, jeremya+watch_chromium.org, dbeam+watch-ntp_chromium.org, robertshield, asvitkine+watch_chromium.org, kalyank, chromium-apps-reviews_chromium.org, Ilya Sherman, ben+ash_chromium.org, pedrosimonetti+watch_chromium.org
Visibility:
Public.

Description

Move LaunchType out of ExtensionPrefs. Move the LaunchType enum and associated LaunchType and LaunchContainer helper methods out of the ExtensionPrefs class and into a new launch_util.h file. This pulls more Chrome-specific code out of ExtensionPrefs so it can someday be moved to the toplevel extensions/ directory. BUG=180083, 313284 TBR=benwells@chromium.org,xiyuan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238946

Patch Set 1 #

Patch Set 2 : remove unneeded includes #

Patch Set 3 : add missing extension.h include for windows #

Total comments: 4

Patch Set 4 : fix indenting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -246 lines) Patch
M chrome/browser/automation/automation_provider_observers.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_apitest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.h View 2 chunks +0 lines, -34 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 1 4 chunks +0 lines, -119 lines 0 comments Download
A chrome/browser/extensions/launch_util.h View 1 1 chunk +59 lines, -0 lines 0 comments Download
A chrome/browser/extensions/launch_util.cc View 1 chunk +136 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_context_menu.cc View 1 2 3 2 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_controller_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_controller_delegate.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_controller_ash.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.cc View 4 chunks +13 lines, -17 lines 0 comments Download
M chrome/browser/ui/ash/launcher/shell_window_launcher_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 6 chunks +14 lines, -11 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_controller_delegate_win.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Daniel Erat
7 years ago (2013-12-04 23:45:21 UTC) #1
Yoyo Zhou
LGTM https://codereview.chromium.org/105733003/diff/40001/chrome/browser/ui/app_list/app_context_menu.cc File chrome/browser/ui/app_list/app_context_menu.cc (right): https://codereview.chromium.org/105733003/diff/40001/chrome/browser/ui/app_list/app_context_menu.cc#newcode251 chrome/browser/ui/app_list/app_context_menu.cc:251: extensions::LAUNCH_TYPE_REGULAR nit: this indent looks funny https://codereview.chromium.org/105733003/diff/40001/extensions/common/constants.h File ...
7 years ago (2013-12-05 02:43:49 UTC) #2
Daniel Erat
https://codereview.chromium.org/105733003/diff/40001/chrome/browser/ui/app_list/app_context_menu.cc File chrome/browser/ui/app_list/app_context_menu.cc (right): https://codereview.chromium.org/105733003/diff/40001/chrome/browser/ui/app_list/app_context_menu.cc#newcode251 chrome/browser/ui/app_list/app_context_menu.cc:251: extensions::LAUNCH_TYPE_REGULAR On 2013/12/05 02:43:50, Yoyo Zhou wrote: > nit: ...
7 years ago (2013-12-05 03:24:34 UTC) #3
Daniel Erat
7 years ago (2013-12-05 03:38:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/105733003/60001
7 years ago (2013-12-05 03:39:03 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=39567
7 years ago (2013-12-05 03:56:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/105733003/60001
7 years ago (2013-12-05 04:08:20 UTC) #7
benwells
lgtm. I think you need more owners but TBR should be fine.
7 years ago (2013-12-05 06:39:27 UTC) #8
benwells
On 2013/12/05 06:39:27, benwells wrote: > lgtm. I think you need more owners but TBR ...
7 years ago (2013-12-05 06:39:50 UTC) #9
commit-bot: I haz the power
7 years ago (2013-12-05 11:33:07 UTC) #10
Message was sent while issue was closed. 
Change committed as 238946

Powered by Google App Engine
This is Rietveld 408576698