Move LaunchType out of ExtensionPrefs.

extensions/common/constants.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_COMMON_CONSTANTS_H_
 #define EXTENSIONS_COMMON_CONSTANTS_H_
 
 #include "base/files/file_path.h"
 
 namespace extensions {
@@ skipping 67 matching lines @@
 // The name of the database inside the profile where chrome-internal
 // extension state resides.
 extern const char kStateStoreName[];
 
 // The name of the database inside the profile where declarative extension
 // rules are stored.
 extern const char kRulesStoreName[];
 
 // Don't remove items or change the order of this enum.  It's used in
 // histograms and preferences.
+// TODO(derat): Move this to chrome/browser/extensions/launch_util.h?

[Yoyo Zhou, 2013/12/05 02:43:50]

I think that would make sense. You can do that in this CL or a later one.

[Daniel Erat, 2013/12/05 03:24:35]

i'll probably save it for another change; i think that there were a fair number
of places to update (i need to double-check that this isn't used by other
classes that live in extensions/ now, too).

i'll likely also rename the values to e.g. LAUNCH_CONTAINER_WINDOW to avoid
possible confusion with the LaunchType values.

 enum LaunchContainer {
   LAUNCH_WINDOW,
   LAUNCH_PANEL,
   LAUNCH_TAB,
   // For platform apps, which don't actually have a container (they just get a
   // "onLaunched" event).
   LAUNCH_NONE
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_COMMON_CONSTANTS_H_