Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

Issue 105733003: Move LaunchType out of ExtensionPrefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix indenting Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
index c03f66b8ae60236ed23ca2723339adf6485d6855..972990fd7dc8d0db6b2cb08f3baf67768cef4601 100644
--- a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
@@ -13,6 +13,7 @@
#include "chrome/browser/extensions/extension_browsertest.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_system.h"
+#include "chrome/browser/extensions/launch_util.h"
#include "chrome/browser/first_run/first_run.h"
#include "chrome/browser/infobars/infobar_service.h"
#include "chrome/browser/managed_mode/managed_mode_navigation_observer.h"
@@ -117,10 +118,10 @@ class StartupBrowserCreatorTest : public ExtensionBrowserTest {
}
void SetAppLaunchPref(const std::string& app_id,
- extensions::ExtensionPrefs::LaunchType launch_type) {
+ extensions::LaunchType launch_type) {
ExtensionService* service = extensions::ExtensionSystem::Get(
browser()->profile())->extension_service();
- service->extension_prefs()->SetLaunchType(app_id, launch_type);
+ extensions::SetLaunchType(service->extension_prefs(), app_id, launch_type);
}
Browser* FindOneOtherBrowserForProfile(Profile* profile,
@@ -298,8 +299,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, OpenAppShortcutWindowPref) {
ASSERT_NO_FATAL_FAILURE(LoadApp("app_with_tab_container", &extension_app));
// Set a pref indicating that the user wants to open this app in a window.
- SetAppLaunchPref(extension_app->id(),
- extensions::ExtensionPrefs::LAUNCH_TYPE_WINDOW);
+ SetAppLaunchPref(extension_app->id(), extensions::LAUNCH_TYPE_WINDOW);
CommandLine command_line(CommandLine::NO_PROGRAM);
command_line.AppendSwitchASCII(switches::kAppId, extension_app->id());
@@ -330,8 +330,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, OpenAppShortcutTabPref) {
ASSERT_NO_FATAL_FAILURE(LoadApp("app_with_tab_container", &extension_app));
// Set a pref indicating that the user wants to open this app in a window.
- SetAppLaunchPref(extension_app->id(),
- extensions::ExtensionPrefs::LAUNCH_TYPE_REGULAR);
+ SetAppLaunchPref(extension_app->id(), extensions::LAUNCH_TYPE_REGULAR);
CommandLine command_line(CommandLine::NO_PROGRAM);
command_line.AppendSwitchASCII(switches::kAppId, extension_app->id());
« no previous file with comments | « chrome/browser/ui/extensions/application_launch.cc ('k') | chrome/browser/ui/startup/startup_browser_creator_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698