Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1057213005: [Telemetry] Rename interaction_record field of value to tir_label. (Closed)

Created:
5 years, 8 months ago by eakuefner
Modified:
5 years, 8 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Rename interaction_record field of value to tir_label. The name 'interaction_record' does not make it sufficiently clear that the so-named field of Value is to be used to indicate the label of the TimelineInteractionRecord to which it pertains. This CL renames it 'tir_label' to make this distinction clear. R=nednguyen BUG=461101 Committed: https://crrev.com/0f8bf3b33319a20fbe475f72c4a0d91d742c5252 Cr-Commit-Position: refs/heads/master@{#323848}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -96 lines) Patch
M tools/telemetry/telemetry/value/__init__.py View 6 chunks +13 lines, -13 lines 0 comments Download
M tools/telemetry/telemetry/value/failure.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/value/histogram.py View 4 chunks +7 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/value/list_of_scalar_values.py View 7 chunks +10 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/value/list_of_string_values.py View 7 chunks +10 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/value/merge_values_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/value/scalar.py View 7 chunks +10 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/value/skip.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/value/string.py View 7 chunks +10 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/value/trace.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/value_unittest.py View 5 chunks +28 lines, -28 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
eakuefner
PTAL, simple renaming-only change
5 years, 8 months ago (2015-04-03 22:41:12 UTC) #1
nednguyen
lgtm
5 years, 8 months ago (2015-04-03 22:48:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057213005/1
5 years, 8 months ago (2015-04-03 22:49:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-03 23:43:23 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 23:44:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f8bf3b33319a20fbe475f72c4a0d91d742c5252
Cr-Commit-Position: refs/heads/master@{#323848}

Powered by Google App Engine
This is Rietveld 408576698