Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: tools/telemetry/telemetry/value/list_of_string_values.py

Issue 1057213005: [Telemetry] Rename interaction_record field of value to tir_label. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/value/list_of_string_values.py
diff --git a/tools/telemetry/telemetry/value/list_of_string_values.py b/tools/telemetry/telemetry/value/list_of_string_values.py
index d69f31abafb7266076055f5d1e5bed4961a8f758..b5e61c539afa9847e85524f820e935a4a3ec0df0 100644
--- a/tools/telemetry/telemetry/value/list_of_string_values.py
+++ b/tools/telemetry/telemetry/value/list_of_string_values.py
@@ -9,10 +9,10 @@ from telemetry.value import none_values
class ListOfStringValues(value_module.Value):
def __init__(self, page, name, units, values,
important=True, description=None,
- interaction_record=None, none_value_reason=None,
+ tir_label=None, none_value_reason=None,
same_page_merge_policy=value_module.CONCATENATE):
super(ListOfStringValues, self).__init__(page, name, units, important,
- description, interaction_record)
+ description, tir_label)
if values is not None:
assert isinstance(values, list)
assert len(values) > 0
@@ -32,7 +32,7 @@ class ListOfStringValues(value_module.Value):
else:
merge_policy = 'PICK_FIRST'
return ('ListOfStringValues(%s, %s, %s, %s, '
- 'important=%s, description=%s, interaction_record=%s, '
+ 'important=%s, description=%s, tir_label=%s, '
'same_page_merge_policy=%s)') % (
page_name,
self.name,
@@ -40,7 +40,7 @@ class ListOfStringValues(value_module.Value):
repr(self.values),
self.important,
self.description,
- self.interaction_record,
+ self.tir_label,
merge_policy)
def GetBuildbotDataType(self, output_context):
@@ -81,8 +81,8 @@ class ListOfStringValues(value_module.Value):
if 'none_value_reason' in value_dict:
kwargs['none_value_reason'] = value_dict['none_value_reason']
- if 'interaction_record' in value_dict:
- kwargs['interaction_record'] = value_dict['interaction_record']
+ if 'tir_label' in value_dict:
+ kwargs['tir_label'] = value_dict['tir_label']
return ListOfStringValues(**kwargs)
@@ -100,7 +100,7 @@ class ListOfStringValues(value_module.Value):
none_value_reason=v0.none_value_reason)
assert v0.same_page_merge_policy == value_module.CONCATENATE
- return cls._MergeLikeValues(values, v0.page, v0.name, v0.interaction_record)
+ return cls._MergeLikeValues(values, v0.page, v0.name, v0.tir_label)
@classmethod
def MergeLikeValuesFromDifferentPages(cls, values,
@@ -108,10 +108,10 @@ class ListOfStringValues(value_module.Value):
assert len(values) > 0
v0 = values[0]
name = v0.name_suffix if group_by_name_suffix else v0.name
- return cls._MergeLikeValues(values, None, name, v0.interaction_record)
+ return cls._MergeLikeValues(values, None, name, v0.tir_label)
@classmethod
- def _MergeLikeValues(cls, values, page, name, interaction_record):
+ def _MergeLikeValues(cls, values, page, name, tir_label):
v0 = values[0]
merged_values = []
none_value_reason = None
@@ -125,6 +125,6 @@ class ListOfStringValues(value_module.Value):
page, name, v0.units,
merged_values,
important=v0.important,
- interaction_record=interaction_record,
+ tir_label=tir_label,
same_page_merge_policy=v0.same_page_merge_policy,
none_value_reason=none_value_reason)
« no previous file with comments | « tools/telemetry/telemetry/value/list_of_scalar_values.py ('k') | tools/telemetry/telemetry/value/merge_values_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698