Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: tools/telemetry/telemetry/value/string.py

Issue 1057213005: [Telemetry] Rename interaction_record field of value to tir_label. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/value/skip.py ('k') | tools/telemetry/telemetry/value/trace.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/value/string.py
diff --git a/tools/telemetry/telemetry/value/string.py b/tools/telemetry/telemetry/value/string.py
index d9e21c6168304843aa1c0b876b59c6d78ef84e92..091dd99b763519b48128e16d0c41289561900b6d 100644
--- a/tools/telemetry/telemetry/value/string.py
+++ b/tools/telemetry/telemetry/value/string.py
@@ -9,7 +9,7 @@ from telemetry.value import none_values
class StringValue(value_module.Value):
def __init__(self, page, name, units, value, important=True,
- description=None, interaction_record=None,
+ description=None, tir_label=None,
none_value_reason=None):
"""A single value (float, integer or string) result from a test.
@@ -18,7 +18,7 @@ class StringValue(value_module.Value):
StringValue(page, 'page_hash', 'hash', '74E377FF')
"""
super(StringValue, self).__init__(page, name, units, important, description,
- interaction_record)
+ tir_label)
assert value is None or isinstance(value, basestring)
none_values.ValidateNoneValueReason(value, none_value_reason)
self.value = value
@@ -30,14 +30,14 @@ class StringValue(value_module.Value):
else:
page_name = None
return ('StringValue(%s, %s, %s, %s, important=%s, description=%s, '
- 'interaction_record=%s)') % (
+ 'tir_label=%s)') % (
page_name,
self.name,
self.units,
self.value,
self.important,
self.description,
- self.interaction_record)
+ self.tir_label)
def GetBuildbotDataType(self, output_context):
if self._IsImportantGivenOutputIntent(output_context):
@@ -75,8 +75,8 @@ class StringValue(value_module.Value):
if 'none_value_reason' in value_dict:
kwargs['none_value_reason'] = value_dict['none_value_reason']
- if 'interaction_record' in value_dict:
- kwargs['interaction_record'] = value_dict['interaction_record']
+ if 'tir_label' in value_dict:
+ kwargs['tir_label'] = value_dict['tir_label']
return StringValue(**kwargs)
@@ -84,7 +84,7 @@ class StringValue(value_module.Value):
def MergeLikeValuesFromSamePage(cls, values):
assert len(values) > 0
v0 = values[0]
- return cls._MergeLikeValues(values, v0.page, v0.name, v0.interaction_record)
+ return cls._MergeLikeValues(values, v0.page, v0.name, v0.tir_label)
@classmethod
def MergeLikeValuesFromDifferentPages(cls, values,
@@ -92,10 +92,10 @@ class StringValue(value_module.Value):
assert len(values) > 0
v0 = values[0]
name = v0.name_suffix if group_by_name_suffix else v0.name
- return cls._MergeLikeValues(values, None, name, v0.interaction_record)
+ return cls._MergeLikeValues(values, None, name, v0.tir_label)
@classmethod
- def _MergeLikeValues(cls, values, page, name, interaction_record):
+ def _MergeLikeValues(cls, values, page, name, tir_label):
v0 = values[0]
merged_value = [v.value for v in values]
none_value_reason = None
@@ -104,5 +104,5 @@ class StringValue(value_module.Value):
none_value_reason = none_values.MERGE_FAILURE_REASON
return list_of_string_values.ListOfStringValues(
page, name, v0.units, merged_value, important=v0.important,
- interaction_record=interaction_record,
+ tir_label=tir_label,
none_value_reason=none_value_reason)
« no previous file with comments | « tools/telemetry/telemetry/value/skip.py ('k') | tools/telemetry/telemetry/value/trace.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698