Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1056793002: Move clear cache code from chrome/ (ChromeWVGDelegate) to extensions/ (WVGuest) (Closed)

Created:
5 years, 8 months ago by lazyboy
Modified:
5 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move-spbdr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move clear cache code from chrome/ (ChromeWVGDelegate) to extensions/ (WVGuest) since browsing_data/ is now under components/ BUG=471287 Test=None, internal only change without visible side effects. Committed: https://crrev.com/d5b8383fee525645421ec70fb031dc5066feadb6 Cr-Commit-Position: refs/heads/master@{#326985}

Patch Set 1 #

Patch Set 2 : Wrote the test! #

Patch Set 3 : Add a missing test file #

Patch Set 4 : fix test on windows #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -144 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 2 3 5 chunks +22 lines, -57 lines 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc View 1 2 3 2 chunks +0 lines, -24 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/clear_data_cache/embedder.js View 1 2 3 2 chunks +97 lines, -34 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/clear_data_cache/guest.html View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/clear_data_cache/guest.js View 1 1 chunk +21 lines, -12 lines 0 comments Download
M extensions/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 2 3 2 chunks +21 lines, -9 lines 2 comments Download
M extensions/browser/guest_view/web_view/web_view_guest_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/extensions.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
lazyboy
+Fady for reviewing first. I'll pass the CL to OWNERs afterwards. I actually got e2e ...
5 years, 8 months ago (2015-04-24 00:51:37 UTC) #2
Fady Samuel
Awesome! It's great to see an end to end test!
5 years, 8 months ago (2015-04-24 01:04:44 UTC) #3
Fady Samuel
lgtm
5 years, 8 months ago (2015-04-24 20:44:35 UTC) #4
lazyboy
+Ken for build and DEPS under extensions/ extensions/DEPS extensions/browser/BUILD.gn extensions/extensions.gyp
5 years, 8 months ago (2015-04-24 20:50:05 UTC) #6
Ken Rockot(use gerrit already)
lgtm
5 years, 8 months ago (2015-04-24 23:34:27 UTC) #7
lazyboy
+Mike for change in extensions/DEPS
5 years, 8 months ago (2015-04-25 00:08:34 UTC) #9
Mike West
LGTM.
5 years, 8 months ago (2015-04-26 07:47:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056793002/60001
5 years, 8 months ago (2015-04-26 14:03:38 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-26 14:58:41 UTC) #13
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/d5b8383fee525645421ec70fb031dc5066feadb6 Cr-Commit-Position: refs/heads/master@{#326985}
5 years, 8 months ago (2015-04-26 14:59:38 UTC) #14
Fady Samuel
https://codereview.chromium.org/1056793002/diff/60001/extensions/browser/guest_view/web_view/web_view_guest.cc File extensions/browser/guest_view/web_view/web_view_guest.cc (right): https://codereview.chromium.org/1056793002/diff/60001/extensions/browser/guest_view/web_view/web_view_guest.cc#newcode728 extensions/browser/guest_view/web_view/web_view_guest.cc:728: return true; I just noticed this early exit. What ...
5 years, 8 months ago (2015-04-26 15:06:07 UTC) #15
lazyboy
5 years, 8 months ago (2015-04-26 15:16:51 UTC) #16
Message was sent while issue was closed.
https://codereview.chromium.org/1056793002/diff/60001/extensions/browser/gues...
File extensions/browser/guest_view/web_view/web_view_guest.cc (right):

https://codereview.chromium.org/1056793002/diff/60001/extensions/browser/gues...
extensions/browser/guest_view/web_view/web_view_guest.cc:728: return true;
On 2015/04/26 15:06:07, Fady Samuel wrote:
> I just noticed this early exit. What happens if you want to clear other pieces
> of data?

ClearDataInternal above in |cache_removal_done_callback| will do that.

Powered by Google App Engine
This is Rietveld 408576698