Move clear cache code from chrome/ (ChromeWVGDelegate) to extensions/ (WVGuest)
since browsing_data/ is now under components/
BUG=471287
Test=None, internal only change without visible side effects.
Committed: https://crrev.com/d5b8383fee525645421ec70fb031dc5066feadb6
Cr-Commit-Position: refs/heads/master@{#326985}
+Fady for reviewing first. I'll pass the CL to OWNERs afterwards. I actually got e2e ...
5 years, 8 months ago
(2015-04-24 00:51:37 UTC)
#2
+Fady for reviewing first.
I'll pass the CL to OWNERs afterwards.
I actually got e2e test for http cache clearing on <webview>
working, yay! I'm doing this by manually setting
"Cache-control" header on the response sent by
EmbeddedTestServer.
Fady Samuel
Awesome! It's great to see an end to end test!
5 years, 8 months ago
(2015-04-24 01:04:44 UTC)
#3
Awesome! It's great to see an end to end test!
Fady Samuel
lgtm
5 years, 8 months ago
(2015-04-24 20:44:35 UTC)
#4
https://codereview.chromium.org/1056793002/diff/60001/extensions/browser/guest_view/web_view/web_view_guest.cc File extensions/browser/guest_view/web_view/web_view_guest.cc (right): https://codereview.chromium.org/1056793002/diff/60001/extensions/browser/guest_view/web_view/web_view_guest.cc#newcode728 extensions/browser/guest_view/web_view/web_view_guest.cc:728: return true; I just noticed this early exit. What ...
5 years, 8 months ago
(2015-04-26 15:06:07 UTC)
#15
Issue 1056793002: Move clear cache code from chrome/ (ChromeWVGDelegate) to extensions/ (WVGuest)
(Closed)
Created 5 years, 8 months ago by lazyboy
Modified 5 years, 8 months ago
Reviewers: Fady Samuel, Ken Rockot(use gerrit already), Mike West
Base URL: https://chromium.googlesource.com/chromium/src.git@move-spbdr
Comments: 2