Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5082)

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

Issue 1056793002: Move clear cache code from chrome/ (ChromeWVGDelegate) to extensions/ (WVGuest) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-spbdr
Patch Set: fix test on windows Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
index 03abc79cb3ed24b627bbf514364ede01c626ea07..ffdb52dae11ff30221b1fe5676a47982c9ecedbe 100644
--- a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
+++ b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
@@ -11,10 +11,8 @@
#include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
#include "chrome/browser/ui/pdf/chrome_pdf_web_contents_helper_client.h"
#include "chrome/common/chrome_version_info.h"
-#include "components/browsing_data/storage_partition_http_cache_data_remover.h"
#include "components/pdf/browser/pdf_web_contents_helper.h"
#include "components/renderer_context_menu/context_menu_delegate.h"
-#include "components/web_cache/browser/web_cache_manager.h"
#include "content/public/browser/render_process_host.h"
#include "extensions/browser/api/web_request/web_request_api.h"
#include "extensions/browser/guest_view/guest_view_event.h"
@@ -42,28 +40,6 @@ ChromeWebViewGuestDelegate::ChromeWebViewGuestDelegate(
ChromeWebViewGuestDelegate::~ChromeWebViewGuestDelegate() {
}
-void ChromeWebViewGuestDelegate::ClearCache(
- base::Time remove_since,
- const base::Closure& done_callback) {
- int render_process_id = guest_web_contents()->GetRenderProcessHost()->GetID();
- // We need to clear renderer cache separately for our process because
- // StoragePartitionHttpCacheDataRemover::ClearData() does not clear that.
- web_cache::WebCacheManager::GetInstance()->Remove(render_process_id);
- web_cache::WebCacheManager::GetInstance()->ClearCacheForProcess(
- render_process_id);
-
- content::StoragePartition* partition =
- content::BrowserContext::GetStoragePartition(
- guest_web_contents()->GetBrowserContext(),
- guest_web_contents()->GetSiteInstance());
-
- // StoragePartitionHttpCacheDataRemover removes itself when it is done.
- // TODO(lazyboy): Once StoragePartitionHttpCacheDataRemover moves to
- // components/, move |ClearCache| to WebViewGuest: http//crbug.com/471287.
- browsing_data::StoragePartitionHttpCacheDataRemover::CreateForRange(
- partition, remove_since, base::Time::Now())->Remove(done_callback);
-}
-
bool ChromeWebViewGuestDelegate::HandleContextMenu(
const content::ContextMenuParams& params) {
ContextMenuDelegate* menu_delegate =

Powered by Google App Engine
This is Rietveld 408576698