Issue 1056143004: Revert of Code's more readable when SkPMFloat is an Sk4f.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1056143004: Revert of Code's more readable when SkPMFloat is an Sk4f. (Closed)

Created:
5 years, 8 months ago by mtklein

Modified:
5 years, 8 months ago

Reviewers:
mtklein_C, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Code's more readable when SkPMFloat is an Sk4f. (patchset #3 id:40001 of https://codereview.chromium.org/1061603002/) Reason for revert: missed some neon code Original issue's description: > Code's more readable when SkPMFloat is an Sk4f. > #floats > > BUG=skia: > BUG=skia:3592 > > Committed: https://skia.googlesource.com/skia/+/6b5dab889579f1cc9e1b5278f4ecdc4c63fe78c9 TBR=reed@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/e758579d4f85f4615d62e87847dd3f8b38e3a6e2

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -34 lines)			Patch
M	src/core/SkPMFloat.h	View	3 chunks	+12 lines, -9 lines	0 comments	Download
M	src/core/SkXfermode.cpp	View	6 chunks	+18 lines, -6 lines	0 comments	Download
M	src/effects/SkColorMatrixFilter.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/opts/SkNx_neon.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/opts/SkNx_sse.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/opts/SkPMFloat_SSE2.h	View	4 chunks	+7 lines, -7 lines	0 comments	Download
M	src/opts/SkPMFloat_SSSE3.h	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	src/opts/SkPMFloat_neon.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

mtklein

Created Revert of Code's more readable when SkPMFloat is an Sk4f.

5 years, 8 months ago (2015-04-03 19:47:28 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056143004/1

5 years, 8 months ago (2015-04-03 19:47:37 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-03 19:47:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e758579d4f85f4615d62e87847dd3f8b38e3a6e2