Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 1055743002: Revert of cc: Make scheduling be driven by vsync for android webview. (Closed)

Created:
5 years, 8 months ago by sunnyps
Modified:
5 years, 8 months ago
CC:
chromium-reviews, jam, cc-bugs_chromium.org, scheduler-bugs_chromium.org, android-webview-reviews_chromium.org, darin-cc_chromium.org, mithro-old
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Make scheduling be driven by vsync for android webview. (patchset #38 id:740001 of https://codereview.chromium.org/817603002/) Reason for revert: Causes a webview test to fail. http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/19230 Original issue's description: > cc: Make scheduling be driven by vsync for android webview. > > This CL makes android webview use the similar mechanisms for > scheduling as other platforms instead of using special > polling code in the scheduler. > > Design Doc: https://docs.google.com/a/chromium.org/document/d/1w5UiuA2uZcAiU9-1Y23bxXaStUThkAK8wHI4ULqho2Y/edit# > > BUG=439275 > > Committed: https://crrev.com/bf27da634790bb6eecf4b89f278cfd55c5e5d1f3 > Cr-Commit-Position: refs/heads/master@{#323361} TBR=brianderson@chromium.org,boliu@chromium.org,enne@chromium.org,danakj@chromium.org,hush@chromium.org,mithro@mithis.com,jdduke@chromium.org,sievers@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=439275 Committed: https://crrev.com/894faa608876e34f9b20ed101ab7aca69de10d15 Cr-Commit-Position: refs/heads/master@{#323415}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+461 lines, -666 lines) Patch
M android_webview/browser/browser_view_renderer.h View 4 chunks +14 lines, -8 lines 0 comments Download
M android_webview/browser/browser_view_renderer.cc View 16 chunks +80 lines, -50 lines 0 comments Download
M android_webview/browser/browser_view_renderer_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/browser/browser_view_renderer_unittest.cc View 7 chunks +27 lines, -14 lines 0 comments Download
M cc/output/begin_frame_args.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/output/begin_frame_args.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/output/output_surface.h View 1 chunk +0 lines, -6 lines 0 comments Download
M cc/output/output_surface_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/scheduler/scheduler.h View 5 chunks +4 lines, -8 lines 0 comments Download
M cc/scheduler/scheduler.cc View 18 chunks +86 lines, -83 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.h View 10 chunks +26 lines, -19 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 20 chunks +121 lines, -136 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 5 chunks +13 lines, -153 lines 0 comments Download
M cc/surfaces/display.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/surfaces/display.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/fake_output_surface.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/fake_output_surface_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/layer_tree_test.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/layer_tree_test.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 3 chunks +1 line, -9 lines 0 comments Download
M cc/trees/thread_proxy.h View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/trees/thread_proxy.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_external_begin_frame_source.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/android/in_process/synchronous_compositor_external_begin_frame_source.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_impl.h View 5 chunks +3 lines, -12 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_impl.cc View 8 chunks +28 lines, -41 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_output_surface.h View 4 chunks +7 lines, -7 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_output_surface.cc View 9 chunks +13 lines, -15 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 4 chunks +23 lines, -34 lines 0 comments Download
M content/public/browser/android/synchronous_compositor.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/browser/android/synchronous_compositor_client.h View 1 chunk +4 lines, -1 line 0 comments Download
M content/public/test/test_synchronous_compositor_android.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
sunnyps
Created Revert of cc: Make scheduling be driven by vsync for android webview.
5 years, 8 months ago (2015-04-02 03:03:21 UTC) #1
mithro-old
lgtm
5 years, 8 months ago (2015-04-02 03:05:04 UTC) #4
boliu
On 2015/04/02 03:05:04, mithro wrote: > lgtm following run passed..
5 years, 8 months ago (2015-04-02 03:05:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055743002/1
5 years, 8 months ago (2015-04-02 03:05:52 UTC) #6
sunnyps
On 2015/04/02 03:05:37, boliu wrote: > On 2015/04/02 03:05:04, mithro wrote: > > lgtm > ...
5 years, 8 months ago (2015-04-02 03:06:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-02 03:07:38 UTC) #8
boliu
Java stack from test fdb7f: 04-02 01:13:39.759 18237 18237 E AndroidRuntime: junit.framework.AssertionFailedError: expected:<-65536> but was:<-16776961> ...
5 years, 8 months ago (2015-04-02 03:09:48 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:22:05 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/894faa608876e34f9b20ed101ab7aca69de10d15
Cr-Commit-Position: refs/heads/master@{#323415}

Powered by Google App Engine
This is Rietveld 408576698