Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 1055123002: New names for SkPMFloat methods. (Closed)

Created:
5 years, 8 months ago by mtklein_C
Modified:
5 years, 8 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

New names for SkPMFloat methods. BUG=skia: Committed: https://skia.googlesource.com/skia/+/3d626834b4b5ee2d6dda34da365dfe40520253aa

Patch Set 1 #

Patch Set 2 : round() in xfermode.cpp #

Patch Set 3 : one more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -79 lines) Patch
M bench/PMFloatBench.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M src/core/SkPMFloat.h View 1 chunk +7 lines, -7 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 2 5 chunks +10 lines, -10 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/opts/SkPMFloat_SSE2.h View 4 chunks +8 lines, -8 lines 0 comments Download
M src/opts/SkPMFloat_SSSE3.h View 3 chunks +11 lines, -11 lines 0 comments Download
M src/opts/SkPMFloat_neon.h View 3 chunks +14 lines, -14 lines 0 comments Download
M src/opts/SkPMFloat_none.h View 2 chunks +12 lines, -12 lines 0 comments Download
M tests/PMFloatTest.cpp View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
mtklein_C
Better land your change first.
5 years, 8 months ago (2015-04-02 18:44:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055123002/1
5 years, 8 months ago (2015-04-02 18:46:32 UTC) #4
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-02 18:52:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055123002/40001
5 years, 8 months ago (2015-04-02 19:50:36 UTC) #8
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-02 20:20:20 UTC) #10
mtklein
ping mike?
5 years, 8 months ago (2015-04-03 13:53:37 UTC) #11
reed1
round and roundClamp sgtm I wonder if we should try adding truncClamp, as well as ...
5 years, 8 months ago (2015-04-03 14:03:50 UTC) #12
reed1
also fine to land this now, and debate the others later, so lgtm
5 years, 8 months ago (2015-04-03 14:04:08 UTC) #13
mtklein
On 2015/04/03 14:04:08, reed1 wrote: > also fine to land this now, and debate the ...
5 years, 8 months ago (2015-04-03 14:04:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055123002/40001
5 years, 8 months ago (2015-04-03 14:05:06 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 14:05:24 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/3d626834b4b5ee2d6dda34da365dfe40520253aa

Powered by Google App Engine
This is Rietveld 408576698