Issue 1055023002: Revert of Add constant color GrFP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1055023002: Revert of Add constant color GrFP. (Closed)

Created:
5 years, 8 months ago by bsalomon

Modified:
5 years, 8 months ago

Reviewers:
egdaniel

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Add constant color GrFP. (patchset #10 id:180001 of https://codereview.chromium.org/978713002/) Reason for revert: Revert while investigating assertions. Original issue's description: > Add constant color GrFP. > > Committed: https://skia.googlesource.com/skia/+/dfbbec436cbcacc3270d4b28357c8393e67d6494 TBR=egdaniel@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/599ea40cec8da11da7ad7c37a2ff0ef4797dbd4a

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -498 lines)			Patch
D	gm/constcolorprocessor.cpp	View	1 chunk	+0 lines, -197 lines	0 comments	Download
M	gyp/gmslides.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gyp/gpu.gypi	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	include/gpu/GrInvariantOutput.h	View	5 chunks	+0 lines, -97 lines	0 comments	Download
M	include/gpu/SkGr.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
D	include/gpu/effects/GrConstColorProcessor.h	View	1 chunk	+0 lines, -64 lines	0 comments	Download
M	src/gpu/GrProcessor.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
D	src/gpu/effects/GrConstColorProcessor.cpp	View	1 chunk	+0 lines, -133 lines	0 comments	Download

Total messages: 4 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055023002/1

5 years, 8 months ago (2015-04-02 15:33:47 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-02 15:33:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/599ea40cec8da11da7ad7c37a2ff0ef4797dbd4a